Review Request 123130: Port away CVS plugin from KDialog

[Dāvis Mosāns]

> On marts 26, 2015, 12:45 a.m., Aleix Pol Gonzalez wrote:
> > plugins/cvs/importdialog.cpp, line 30
> > <https://git.reviewboard.kde.org/r/123130/diff/1/?file=356590#file356590line30>
> >
> >     Doesn't this dialog even need a close button?

I don't even know how it looks like :D and I don't see anywhere any signals regarding buttons like accepted/rejected/*Clicked... so I don't know.
but I guess, I can add QDialogButtonBox::Ok


> On marts 26, 2015, 12:45 a.m., Aleix Pol Gonzalez wrote:
> > plugins/cvs/importdialog.cpp, line 35
> > <https://git.reviewboard.kde.org/r/123130/diff/1/?file=356590#file356590line35>
> >
> >     This will happen automatically if you pass the new layout in setLayout, before creating the widget.

so this would be better?
```cpp
auto layout = new QVBoxLayout();
setLayout(layout);
layout->addWidget(m_widget);
```


- Dāvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123130/#review78052
-----------------------------------------------------------


On marts 25, 2015, 8:34 p.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123130/
> -----------------------------------------------------------
> 
> (Updated marts 25, 2015, 8:34 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Port away CVS plugin from KDialog
> 
> 
> Diffs
> -----
> 
>   plugins/cvs/CMakeLists.txt 52b9b890952bb386c316cf5b0ef030ae4f56ae36 
>   plugins/cvs/checkoutdialog.h 9f8775279761b9123d12ede7df83bae5894baea2 
>   plugins/cvs/checkoutdialog.cpp ba9acd42a638b1041130e4e972526de012bef1a2 
>   plugins/cvs/checkoutdialog.ui 24f01c34b192df63d5a2e8b6cd48a994d93f5c0e 
>   plugins/cvs/cvsplugin.cpp 35e763af30c3d65547dfa6e63ac72c51f9ce6726 
>   plugins/cvs/importdialog.h 1e4ec6b88e4ea9c86383c492adbf2a318b712ae1 
>   plugins/cvs/importdialog.cpp 2be84eaf2f4d3323e540f5279ea09c359c1b0af3 
> 
> Diff: https://git.reviewboard.kde.org/r/123130/diff/
> 
> 
> Testing
> -------
> 
> Compiles and I think it should work, but can't test because CVS plugin don't even get loaded.
> Don't know why...
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150326/d6101871/attachment.html>