Review Request 123123: JSONized kdev-cppcheck

[Laszlo Kis-Adam]

> On March 24, 2015, 8:20 p.m., Alex Richardson wrote:
> > kcm_kdev_cppcheck.json.cmake, line 46
> > <https://git.reviewboard.kde.org/r/123123/diff/1/?file=356510#file356510line46>
> >
> >     I think this should be a list although I'm not sure it is still required
> 
> Laszlo Kis-Adam wrote:
>     Explain please.
>     I used the desktoptojson tool to create the json files. I am not familiar with their contents.
> 
> Alex Richardson wrote:
>     The problem is that some properties are meant to be string lists, but the desktoptojson tool doesn't know about that.
>     I wrote an initial patch (https://git.reviewboard.kde.org/r/121672/) to fix that, but I'm not happy with the result and haven't got round to finding a better solution.
> 
> Laszlo Kis-Adam wrote:
>     So then what should I do here?
> 
> Aleix Pol Gonzalez wrote:
>     "X-KDE-ParentComponents": [ "kdevplatformproject", "kdevcppcheck" ],

Thanks Aleix!


- Laszlo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123123/#review78022
-----------------------------------------------------------


On March 25, 2015, 12:57 a.m., Laszlo Kis-Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123123/
> -----------------------------------------------------------
> 
> (Updated March 25, 2015, 12:57 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-cppcheck
> 
> 
> Description
> -------
> 
> JSONized kdev-cppcheck
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 986f099 
>   config/genericconfigpage.cpp 69e3395 
>   kcm_kdev_cppcheck.desktop e261e2e 
>   kcm_kdev_cppcheck.json PRE-CREATION 
>   kdevcppcheck.desktop.cmake ddb7e03 
>   kdevcppcheck.json PRE-CREATION 
>   plugin.cpp fb193ca 
> 
> Diff: https://git.reviewboard.kde.org/r/123123/diff/
> 
> 
> Testing
> -------
> 
> Built.
> Loaded.
> It works.
> 
> 
> Thanks,
> 
> Laszlo Kis-Adam
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150324/4d32dcc7/attachment.html>