Review Request 123123: JSONized kdev-cppcheck

[Alex Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123123/#review78022
-----------------------------------------------------------

Ship it!



kcm_kdev_cppcheck.json.cmake (line 46)
<https://git.reviewboard.kde.org/r/123123/#comment53463>

    I think this should be a list although I'm not sure it is still required



kdevcppcheck.json.cmake (line 69)
<https://git.reviewboard.kde.org/r/123123/#comment53464>

    No longer required -> you can remove the configure_file()


- Alex Richardson


On March 24, 2015, 6:46 p.m., Laszlo Kis-Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123123/
> -----------------------------------------------------------
> 
> (Updated March 24, 2015, 6:46 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-cppcheck
> 
> 
> Description
> -------
> 
> JSONized kdev-cppcheck
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 986f099 
>   config/genericconfigpage.cpp 69e3395 
>   kcm_kdev_cppcheck.desktop e261e2e 
>   kcm_kdev_cppcheck.json.cmake PRE-CREATION 
>   kdevcppcheck.desktop.cmake ddb7e03 
>   kdevcppcheck.json.cmake PRE-CREATION 
>   plugin.cpp fb193ca 
> 
> Diff: https://git.reviewboard.kde.org/r/123123/diff/
> 
> 
> Testing
> -------
> 
> Built.
> Loaded.
> It works.
> 
> 
> Thanks,
> 
> Laszlo Kis-Adam
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150324/cf19aa5a/attachment.html>