Review Request 123120: JSONized kdev-valgrind

[Alex Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123120/#review78021
-----------------------------------------------------------

Ship it!



kdevvalgrind.json.cmake (line 92)
<https://git.reviewboard.kde.org/r/123120/#comment53462>

    X-KDevelop-Version can be removed and then you no longer need configure_file()


- Alex Richardson


On March 24, 2015, 6:24 p.m., Laszlo Kis-Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123120/
> -----------------------------------------------------------
> 
> (Updated March 24, 2015, 6:24 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-valgrind
> 
> 
> Description
> -------
> 
> JSONized kdev-valgrind
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c02fcf9 
>   kdevvalgrind.desktop.cmake a46bc7a 
>   kdevvalgrind.json.cmake PRE-CREATION 
>   plugin.cpp 3112d50 
> 
> Diff: https://git.reviewboard.kde.org/r/123120/diff/
> 
> 
> Testing
> -------
> 
> Built successfully.
> Loaded successfully.
> Works fine.
> 
> 
> Thanks,
> 
> Laszlo Kis-Adam
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150324/57bfda42/attachment.html>