Review Request 119830: Remove deprecated IProject methods

[Dāvis Mosāns]

> On Oct. 15, 2014, 5:05 p.m., Milian Wolff wrote:
> > I'm OK with this landing, but imo we must first port the other modules, otherwise they will all fail to compile. Can you make sure that is the case? Otherwise commit this but do not remove the deprecated methods yet.
> 
> Dāvis Mosāns wrote:
>     KDevelop can't be compiled with this, it uses project->folder and maybe other methods. Need to update KDevelop first.
> 
> Milian Wolff wrote:
>     you should then tackle such issues from the other way around. I.e. first fix KDevelop and the other important plugins, then adopt KDevplatform. The way it is now, this just keeps this useful work in review limbo :-/
> 
> Dāvis Mosāns wrote:
>     true, but this all started accidently... I didn't really planned for it. So let's say things happened and I've a bit of KDevPlatform code to still submit. Anyway I haven't looked into KDevelop yet so you can do that part so this patch could be merged.
> 
> Aleix Pol Gonzalez wrote:
>     Have you checked now? :D

Currently KDevelop still won't compile, it needs to be updated first, I'll probably look into it this week.


- Dāvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119830/#review68454
-----------------------------------------------------------


On marts 21, 2015, 6:19 a.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119830/
> -----------------------------------------------------------
> 
> (Updated marts 21, 2015, 6:19 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Remove deprecated IProject methods. No need to keep them, when KUrl will be changed to QUrl signatures would be different anyway, so just remove now.
> 
> 
> Diffs
> -----
> 
>   interfaces/iproject.h bdfd66557dc9d9eebe4f8773e0428a8183ec1825 
>   plugins/execute/nativeappconfig.cpp 9c83db9e021201b0732ce186423a3d922458262d 
>   plugins/executescript/scriptappconfig.cpp 947cc464a42e3c18c38034287c93bdcb4ae8726c 
>   plugins/externalscript/externalscriptjob.cpp e65516d65e9315129bb8a9efc6d8897b4413cde6 
>   plugins/filetemplates/templateclassassistant.cpp 8681590b8e15ed1f3ceb15cba118733eb67c7e06 
>   plugins/grepview/grepdialog.cpp 4671c30bcdb75699d0cd474da78cfbf15eadf535 
>   plugins/projectmanagerview/projectmanagerview.cpp 95ae9a90273ec4f4be57fdc5e526e4416440788f 
>   plugins/projectmanagerview/vcsoverlayproxymodel.cpp 62e632c9c6e243d4a34626837f9232b3a3cc3f2a 
>   project/projectmodel.h e7513ff99cdb8f1724828e7e4d338c0fdcf1a7fa 
>   project/projectmodel.cpp 49cd984bdcbba661fedd8fbf42912b43fa28b733 
>   shell/project.h aec5be208c058a17540b3646dd4a8a0a12a29750 
>   shell/project.cpp e7e6efa462e8000c566af265d441464b5ab5cdce 
>   shell/projectcontroller.cpp 50bdce4b47c16a4e62c8b7014897a6ae12d6bba6 
>   tests/testproject.h 06757db24be0a356f4a0aee27f07899b6ea906b7 
>   tests/testproject.cpp 39a6d0be6505fcb7f5e130f27481fe02b89a7446 
>   vcs/models/brancheslistmodel.cpp 0737f8bcb8f855ac0901be6885428721218acefb 
> 
> Diff: https://git.reviewboard.kde.org/r/119830/diff/
> 
> 
> Testing
> -------
> 
> Tests does pass :)
> 
> but note that KDevelop must also be updated and currently it won't compile against this because it still uses these deprecated methods.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150321/3ce11802/attachment-0001.html>