Review Request 123092: Remove fileutils

Aleix Pol Gonzalez aleixpol at kde.org
Sat Mar 21 16:12:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123092/#review77885
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On March 21, 2015, 6:10 a.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123092/
> -----------------------------------------------------------
> 
> (Updated March 21, 2015, 6:10 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Remove fileutils
> 
> util/fileutils.h contains only removeDirectory function, better just use QDir().removeRecursively()
> It's unlikly that any other fileutils functions will be needed as everything can be done with Qt
> 
> 
> Diffs
> -----
> 
>   serialization/itemrepositoryregistry.cpp f59d6d2c3d959f5d222e0cdcbcdd16dc42affbd6 
>   shell/session.cpp 079e3ce63b1698446f1d35b7de6c8da73beca50c 
>   shell/sessioncontroller.cpp 086b1195e3fe9078b75354b7287087458b3f8897 
>   util/CMakeLists.txt f03b2b9cfee7c42d72f783f6b6dad986f3aab766 
>   util/fileutils.h 611e79d509dc23a324559898dd8bd32a6c1e6d7f 
>   util/fileutils.cpp 134d678d8fd0c78c45a24f41b2e102784e88a21a 
> 
> Diff: https://git.reviewboard.kde.org/r/123092/diff/
> 
> 
> Testing
> -------
> 
> It compiles.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150321/439de627/attachment.html>


More information about the KDevelop-devel mailing list