Review Request 122388: Custom Build System human readable defines and include search path for KDevelop kf5/master

Salamander Purake salamanderrake at gmail.com
Fri Mar 20 18:23:27 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122388/
-----------------------------------------------------------

(Updated March 20, 2015, 6:23 p.m.)


Review request for KDevelop.


Changes
-------

Applied fixes for Sergey Kalinichev


Repository: kdevelop


Description
-------

Made the defines and include path lists human readable by removing the QDataStream and QByte types from the save load steps.


Diffs (updated)
-----

  languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp df2c425 
  languages/plugins/custom-definesandincludes/compilerprovider/tests/test_compilerprovider.h e92ebc0 
  languages/plugins/custom-definesandincludes/compilerprovider/tests/test_compilerprovider.cpp f9fb7fe 

Diff: https://git.reviewboard.kde.org/r/122388/diff/


Testing
-------

create/load a custom build system project (${project-name}.kdev4) add defines and includes path to project via in the text file and the dialog. Tested the defines lines inside the source code files and the autocompletion also in the code files.


Thanks,

Salamander Purake

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150320/a7144d46/attachment.html>


More information about the KDevelop-devel mailing list