Review Request 122874: for plugincontroller.cpp

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122874/#review77695
-----------------------------------------------------------


That's not done yet...

- Aleix Pol Gonzalez


On March 18, 2015, 6:08 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122874/
> -----------------------------------------------------------
> 
> (Updated March 18, 2015, 6:08 p.m.)
> 
> 
> Review request for KDevelop, Alex Richardson and Milian Wolff.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> 9. 3. 2015
> 
> As a newcomer I don't set all the environment variables I should have set!
> This gives me the opportunity to check the error messages I might get.
> 
> So happens to me as I start kdevelop.
> I get a window but it doesn't really work.
> I just get the error message:
> Can't load plugin "KDevXyz123" because a factory to load the plugin could not be obtained: "The shared library was not found."
> 
> This is for a newcomer as I too little help.
> 
> 1.
> My proposal generates a longer message such as:
> Can't load plugin "KDevXyz123" "The shared library was not found." 
> Plugin search paths are ("/usr/lib/qt/plugins", "/usr/local/bin", "/home/guy-kde/.kde/lib/kde4/plugins", "/usr/lib/kde4/plugins") 
> The environment variable QT_PLUGIN_PATH might be not correctly set
> And some more...
> 
> 2.
> I put this before the line:
>     auto factory = loader.factory();
> 
> because it is not wise to look for a factory if the loader is not correct.
> 
> 3. 
> The method PluginController::loadPluginInternal( const QString &pluginId )
> returns a IPlugin *, which might be nullptr.
> 
> Some of the calls of this method take care of the return value, some others not.
> Should it be wise to care care at every calls?
> 
> 
> Diffs
> -----
> 
>   shell/plugincontroller.cpp 362bfb07cea3ae10921027a6f41f4d47913eed7c 
> 
> Diff: https://git.reviewboard.kde.org/r/122874/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150318/70264659/attachment.html>