Review Request 122975: small changes to enhance CppLanguageSupport::specialLanguageObjectNavigationWidget and g++ extension.

Kevin Funk kfunk at kde.org
Mon Mar 16 10:00:52 UTC 2015



> On March 16, 2015, 8:18 a.m., Kevin Funk wrote:
> > languages/cpp/setuphelpers.cpp, line 46
> > <https://git.reviewboard.kde.org/r/122975/diff/1/?file=355232#file355232line46>
> >
> >     Unrelated, see other review-request.
> 
> Zhang HuiJie wrote:
>     "__restrict__" was widely used in these files:
>     
>     /usr/include/c++/${your_g++_version}/ext/pool_allocator.h
>     /usr/include/c++/${your_g++_version}/bits/valarray_array.h
>     /usr/include/c++/${your_g++_version}/valarray
>     
>     Add this type qualifier just as a macro will make our kdevelop work better while parse these code.
>     Or I can make kdevelop treat it as a  type qualifier, but C++ does not have standard support for restrict.

Not saying it is wrong, but it's part of the other review-request already. Let's discuss there


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122975/#review77546
-----------------------------------------------------------


On March 16, 2015, 7:56 a.m., Zhang HuiJie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122975/
> -----------------------------------------------------------
> 
> (Updated March 16, 2015, 7:56 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> small changes to enhance CppLanguageSupport::specialLanguageObjectNavigationWidget and g++ extension.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cpplanguagesupport.cpp a0f47b1 
>   languages/cpp/setuphelpers.cpp cbd78b9 
> 
> Diff: https://git.reviewboard.kde.org/r/122975/diff/
> 
> 
> Testing
> -------
> 
> 1, this patch will make kdevelop work well with these code:
> #define A() function_body;
> #define B A;
> //call B;
> B();
> the  function like macro "foreach" is defined by this way in Qt .
> 
> 2, remove  extra spaces and the fomatter wiil work better.
> 
> 3, __restrict__ is supported by g++ too, add it just like __restrict.
> 
> 
> Thanks,
> 
> Zhang HuiJie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150316/ac29d742/attachment.html>


More information about the KDevelop-devel mailing list