Review Request 122905: Update kdev-valgrind to KF5 compatibility

[Laszlo Kis-Adam]

> On March 12, 2015, 1:23 a.m., Aleix Pol Gonzalez wrote:
> > models/massifitem.cpp, line 126
> > <https://git.reviewboard.kde.org/r/122905/diff/1/?file=354383#file354383line126>
> >
> >     This doesn't make much sense, you're overriding the m_dir path there.
> 
> Laszlo Kis-Adam wrote:
>     I followed the kdev-cppcheck's update, as instructed.
>     https://projects.kde.org/projects/playground/devtools/plugins/kdev-cppcheck/repository/revisions/a0dbe410b752b84a82b96d00231048c1a5cd88ff/diff
>     
>     Also as far as I can tell the KUrl version did the same. So if it's pointless, the original code is at fault.
>     Remember most of this code I did NOT write, I simply updated it.
> 
> Aleix Pol Gonzalez wrote:
>     Yes, just checked it and kdev-cppcheck is also in the wrong. That's not a reason to get this issue proceed though...
> 
> Laszlo Kis-Adam wrote:
>     I understand, but remember, I am new so at first I wanted to follow conventions, easier to not make mistakes that way ;)

I removed cleanpath as that destroyed the URL basically, the rest stays as they are needed. See the changes between revision 1 and 2 of the diff.


- Laszlo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122905/#review77319
-----------------------------------------------------------


On March 13, 2015, 12:02 a.m., Laszlo Kis-Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122905/
> -----------------------------------------------------------
> 
> (Updated March 13, 2015, 12:02 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-valgrind
> 
> 
> Description
> -------
> 
> Updated kdev-valgrind to be compatible with KF5
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 31aaf52 
>   cmake/FindKDevPlatform.cmake 1a771c5 
>   config.h a7ec923 
>   config.cpp 9924dca 
>   config/cachegrindconfigpage.h 070fc06 
>   config/cachegrindconfigpage.cpp a487cc5 
>   config/callgrindconfigpage.h eefbb18 
>   config/callgrindconfigpage.cpp 2c97477 
>   config/genericconfigpage.h e6c9108 
>   config/genericconfigpage.cpp d0147f9 
>   config/helgrindconfigpage.h 497e328 
>   config/helgrindconfigpage.cpp 3fd97bd 
>   config/massifconfigpage.h 64f0f11 
>   config/massifconfigpage.cpp 49660af 
>   config/memcheckconfigpage.h f1d5925 
>   config/memcheckconfigpage.cpp 3a661db 
>   config/ui/cachegrindconfig.ui 170731e 
>   config/ui/callgrindconfig.ui fbb003d 
>   config/ui/genericconfig.ui a09f301 
>   config/ui/helgrindconfig.ui 6cead3c 
>   config/ui/massifconfig.ui 6d4a8de 
>   config/ui/memcheckconfig.ui 11a163e 
>   config/valgrindcachegrindconfigpage.h 73f65de 
>   config/valgrindcachegrindconfigpage.cpp 22b349b 
>   config/valgrindcallgrindconfigpage.h fbdc90d 
>   config/valgrindcallgrindconfigpage.cpp 5820af3 
>   config/valgrindgenericconfigpage.h cdaf0a8 
>   config/valgrindgenericconfigpage.cpp e05ef52 
>   config/valgrindhelgrindconfigpage.h c7487c2 
>   config/valgrindhelgrindconfigpage.cpp b6e877d 
>   config/valgrindmassifconfigpage.h 62e3e79 
>   config/valgrindmassifconfigpage.cpp 9165f6e 
>   config/valgrindmemcheckconfigpage.h 431040a 
>   config/valgrindmemcheckconfigpage.cpp 7c4f92f 
>   debug.h PRE-CREATION 
>   debug.cpp PRE-CREATION 
>   job.h ec4b1b0 
>   job.cpp cf832c4 
>   jobs/cachegrindjob.cpp 0028a62 
>   jobs/callgrindjob.cpp 627e4f7 
>   jobs/massifjob.cpp 9fe2fde 
>   jobs/memcheckjob.cpp 6912760 
>   kdevvalgrind.desktop fb76bb6 
>   kdevvalgrind.desktop.cmake PRE-CREATION 
>   launcher.h 539e34f 
>   launcher.cpp d9b52af 
>   marks.cpp ff2c890 
>   models/cachegrinditem.h 311d228 
>   models/cachegrinditem.cpp 1b50b63 
>   models/cachegrindmodel.cpp 70cad22 
>   models/callgrinditem.h 11c4a33 
>   models/callgrinditem.cpp 845104b 
>   models/callgrindmodel.cpp 5dc971c 
>   models/massifitem.h 6460fba 
>   models/massifitem.cpp 33cd92d 
>   models/massifmodel.cpp 4d5f66a 
>   models/memcheckitemsimpl.h 111e4a6 
>   models/memcheckitemsimpl.cpp fdee8d2 
>   models/memcheckmodel.cpp 2b96fbe 
>   parsers/cachegrindparser.h 312f09a 
>   parsers/cachegrindparser.cpp f82fd8a 
>   parsers/callgrindparser.h e7f522d 
>   parsers/callgrindparser.cpp 5ffe4c9 
>   parsers/massifparser.h 1a97f3b 
>   parsers/memcheckparser.h 2e3d5ae 
>   parsers/memcheckparser.cpp cf438ea 
>   plugin.h e0410e4 
>   plugin.cpp 3cd2448 
>   statjob.h PRE-CREATION 
>   statjob.cpp PRE-CREATION 
>   views/cachegrindview.cpp 591f217 
>   views/callgrindview.cpp 6aa551d 
>   views/massifview.cpp 7bb275f 
>   views/memcheckview.cpp 95961fb 
>   widget.cpp 18eacf7 
> 
> Diff: https://git.reviewboard.kde.org/r/122905/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Laszlo Kis-Adam
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150312/510bf3ec/attachment-0001.html>