Review Request 122898: port kdev-control-graph to kf5

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122898/#review77281
-----------------------------------------------------------



CMakeLists.txt
<https://git.reviewboard.kde.org/r/122898/#comment53068>

    Not needed anymore



CMakeLists.txt
<https://git.reviewboard.kde.org/r/122898/#comment53069>

    Please fix it then. Also worksforme, I think. Can you maybe point out what's wrong actually?



duchaincontrolflow.cpp
<https://git.reviewboard.kde.org/r/122898/#comment53071>

    IIRC, there's a .url() method you can use there. This way you don't need to construct.
    
    In fact, it's wrong, otherwise you should use QUrl(). .str() will return already a url, no need to do the ::fromLocalFile (which prefixes the file://)



duchaincontrolflow.cpp
<https://git.reviewboard.kde.org/r/122898/#comment53072>

    You have the same thing twice: textDocument && textDocument.


- Aleix Pol Gonzalez


On March 11, 2015, 2:10 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122898/
> -----------------------------------------------------------
> 
> (Updated March 11, 2015, 2:10 a.m.)
> 
> 
> Review request for KDevelop and Sandro Andrade.
> 
> 
> Repository: kdev-control-flow-graph
> 
> 
> Description
> -------
> 
> quick and dirty port
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt bf65ed3 
>   controlflowgraphfiledialog.h 51217d6 
>   controlflowgraphfiledialog.cpp f790efd 
>   controlflowgraphnavigationcontext.cpp 8bf1d21 
>   controlflowgraphview.cpp 0a9ba01 
>   duchaincontrolflow.h 69d5eec 
>   duchaincontrolflow.cpp d94f55d 
>   duchaincontrolflowinternaljob.h ffb6da5 
>   duchaincontrolflowinternaljob.cpp 67132a5 
>   duchaincontrolflowjob.h 756c600 
>   duchaincontrolflowjob.cpp 158e6f6 
>   kdevcontrolflowgraphview.desktop.cmake 27b94d0 
>   kdevcontrolflowgraphview.json PRE-CREATION 
>   kdevcontrolflowgraphviewplugin.cpp 44cc60d 
> 
> Diff: https://git.reviewboard.kde.org/r/122898/diff/
> 
> 
> Testing
> -------
> 
> used it, together with the kgraphview port in the other review request.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150311/0a6aa329/attachment.html>