Review Request 122658: Adds ClangFormat to kdevcustomscript_plugin

Mario Bielert mario.bielert at tu-dresden.de
Wed Mar 4 00:43:35 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122658/
-----------------------------------------------------------

(Updated März 4, 2015, 12:43 vorm.)


Review request for KDevelop.


Changes
-------

I worked on your proposals.

Additionally I realized an issue within the .clang-format style. In order to find an appropriate .clang-format file, the current working directory must be set to a sane value. In the formatSourceWithStyle() method it now first tried to set the current working directory to the directory of the passed url. If the directory is not set properly, it's set to the projects base directory.
As there wasn't a cwd set before, I don't think, this will break any existing formatters.


Repository: kdevelop


Description
-------

This patch adds ClangFormat as a predefinded style to customscript_plugin formatter


Diffs (updated)
-----

  formatters/customscript/customscript_plugin.cpp 8e2e6bb 

Diff: https://git.reviewboard.kde.org/r/122658/diff/


Testing
-------

Not much testing required, as it's just a few lines adding the command line and a name.


Thanks,

Mario Bielert

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150304/910e9b2c/attachment.html>


More information about the KDevelop-devel mailing list