Review Request 122756: [OS X] buildsystem: find python3 executable and libraries

[René J.V. Bertin]

> On March 1, 2015, 1:41 a.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 10
> > <https://git.reviewboard.kde.org/r/122756/diff/1/?file=352376#file352376line10>
> >
> >     ${kdevpython_SOURCE_DIR}/cmake and ${CMAKE_SOURCE_DIR}/cmake/modules seems to be the same.

That's what I though too, but without the line I added the extra modules aren't found. Where is `kdevpython_SOURCE_DIR` defined, did I overlook it?


> On March 1, 2015, 1:41 a.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 20
> > <https://git.reviewboard.kde.org/r/122756/diff/1/?file=352376#file352376line20>
> >
> >     Why is a separate finder needed? It seems like it was already looking for python 3.0.
> >     
> >     Can we maybe fix PythonInterp?

Indeed, on Linux the original code seems to work, so the use of the dedicated finder could be limited to `if(APPLE)`. I did take a quick look at the stock FindPythonInterp (and FindPythonLibs) but without more feedback from the CMake ML and lacking intimate knowledge of "cmaking" (which seems to be required here) I preferred to follow the only hint I'd gotten on that ML.

I'm a bit surprised, in fact. Usually asking on the CMake ML is very effective when someone replies to tell you what you're doing wrong. Maybe there *is* a bug here (though it's more likely the fact I'm trying to find a Python version installed through MacPorts that's not been foreseen).


> On March 1, 2015, 1:41 a.m., Aleix Pol Gonzalez wrote:
> > parser/CMakeLists.txt, line 16
> > <https://git.reviewboard.kde.org/r/122756/diff/1/?file=352380#file352380line16>
> >
> >     Same thing

Yep - see my same thing reply :)


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122756/#review76789
-----------------------------------------------------------


On Feb. 28, 2015, 5:55 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122756/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2015, 5:55 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDevelop.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> I encountered issues trying to configure kdev-python v1.7.1-py3 on OS X to build against MacPorts: the build system didn't pick up the correct Python version.
> 
> Someone on the CMake ML pointed me to Python3-specific versions of CMake's FindPython modules, and after some adaptation those seem to do the trick.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 18ecfc0 
>   cmake/CMakeLists.txt PRE-CREATION 
>   cmake/modules/FindPython3Interp.cmake PRE-CREATION 
>   cmake/modules/FindPython3Libs.cmake PRE-CREATION 
>   parser/CMakeLists.txt 1058d76 
> 
> Diff: https://git.reviewboard.kde.org/r/122756/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.5/MacPorts.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150301/6a1b0f55/attachment-0001.html>