Review Request 124201: Extend builder API to be able to install into a suggested prefix
Milian Wolff
mail at milianw.de
Mon Jun 29 14:07:50 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124201/#review81864
-----------------------------------------------------------
project/interfaces/iprojectbuilder.h (line 54)
<https://git.reviewboard.kde.org/r/124201/#comment56184>
mention the specificPrefix?
also, could/should we merge it with the above install method and give a default arg to `const QUrl& specificPrefix = {}`?
style: put `&` next to typename.
- Milian Wolff
On June 28, 2015, 6:37 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124201/
> -----------------------------------------------------------
>
> (Updated June 28, 2015, 6:37 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> Due to some work stuff I'm doing, I realized it would be really cool if I could automatize some package generation (for the curious: kde:scratch/apol/kdev-debdeploy).
>
> What we're trying to achieve, is exactly what make's DESTDIR coding convention does:
> https://www.gnu.org/prep/standards/html_node/DESTDIR.html
>
> See KDevelop patch, which is where things actually change: https://git.reviewboard.kde.org/r/124202/
>
>
> Diffs
> -----
>
> project/interfaces/iprojectbuilder.h 9d65ff6
>
> Diff: https://git.reviewboard.kde.org/r/124201/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150629/1b3b95fa/attachment.html>
More information about the KDevelop-devel
mailing list