Review Request 124123: Feedback request. Problems ToolView GUI changes and ProblemModel refactoring.

Sun Jun 28 18:04:21 UTC 2015

> On June 27, 2015, 8:58 p.m., Aleix Pol Gonzalez wrote:
> > interfaces/iproblem.h, line 95
> > <https://git.reviewboard.kde.org/r/124123/diff/2/?file=381567#file381567line95>
> >
> >     Drop the get* on every getter. We use Qt's API naming scheme.
> 
> Laszlo Kis-Adam wrote:
>     Problem is there are already methods with the same name, and you cannot overload by return type. So I was forced to type a get there.
>     I could drop the conflicting getters, but then I'd have to change every and all occurence in both KDevelop, KDevplatform, and all plugins. So as a compromise I used getSomething() format instead.
> 
> Aleix Pol Gonzalez wrote:
>     Well, if there's any moment at all where we can change anything in the API, that's now.
>     
>     What is the conflict to be precise?
> 
> Laszlo Kis-Adam wrote:
>     I've already explained it in the post that you reacted to :)
>     Methods with the same name, but different return type, and in C++ you cannot overload by return type.
>     So as an example, there's already a method like
>     ProblemData::Severity severity() const;
>     Therefore I cannot create a method like
>     Severity severity() const;
>     
>     (Unless like I said change every and all occurence)
> 
> Aleix Pol Gonzalez wrote:
>     And there again, we see 2 structures that are practically the same: IProblem::Severity and ProblemData::Severity. Maybe we can just kill ProblemData::Severity.

We can definitely do that (and we should, and by we I mean I :D). However then each and every occurence will have to be changed.
That's why I haven't done it YET. This is an iterative process :)
Obviously that will be one of the next stops.

- Laszlo

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124123/#review81819
-----------------------------------------------------------

On June 28, 2015, 7:33 p.m., Laszlo Kis-Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124123/
> -----------------------------------------------------------
> 
> (Updated June 28, 2015, 7:33 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Hi there!
> Here's the bottomline of what I've been doing:
> Please DO note that this is NOT done yet, I'm only submitting it to get some feedback.
> So it should NOT be merged!
> 
> (mostly)GUI changes:
> ====================
> - Moved ProblemModel to shell
> - Reworked the Problems toolview a little. Now it works like this:
> -- ProblemModels are added to ProblemModelSet.
> -- ProblemReporterFactory makes instances of ProblemsView.
> -- ProblemsView takes the models from ProblemModelSet (also subscribes for updates about them, so if one is added or removed it can add/remove their views) and it provides a tabbed widget where the views for them can be added. It creates instances of ProblemTreeView which show the problems in ProblemModel, and adds them to the tabs. Also the tabs shows the number of problems in the ProblemModels.
> -- The toolview will only add actions that are supported by the model (for example: filtering, grouping, reparsing, showing imports. Obviously reparsing doesn't make sense for runtime problem checkers)
> 
> See video:
> https://www.youtube.com/watch?v=K-wcoXcz-GM
> 
> 
> ProblemModel details:
> =====================
> - Broke up ProblemModel into 2 parts
> -- Base ProblemModel that provides the QAbstractItemModel interface for views and can use various ProblemStores to store problems. By default it uses FilteredProblemStore.
> -- ProblemReporterModel is basically the old ProblemModel that grabs problems from DUChain, it's a subclass of ProblemModel.
> - ProblemStore simply stores problems as a list (well technically it stores them in a tree, but it only has 1 level, so it's a list). There's no filtering, no grouping. It's perfect for ProblemReporterModel since it does filtering itself when grabbing the problems from DUChain.
> - FilteredProblemStore DOES filtering, and grouping itself. It stores problems in a tree (ProblemStoreNode subclasses). The tree structure depends on the grouping method, which is implemented with GroupingStrategy subclasses.
> - Moved WatchedDocumentSet and it's subclasses from ProblemModel to ProblemStore, as it is really a detail that the model itself doesn't need, however ProblemStore which stores the problems needs it actually.
> - Created a new Problem class, DetectedProblem. The intent here was to create a class with a clear interface for problems, which ProblemStore can simply store. Then I wanted to eventually replace the "old" Problem class with it. Then I realized that it's not practical because of the "show imports" feature. Which shows the problems from imported contexts. Unfortunately DUChain is the class that knows those, and it's way too much work to get it out from it. Not to mention it doesn't even make sense, since it's really something that logically belongs there. 
> Therefore my current plan now is to just bring them under a common interface so that it will not matter at all. The connection to DUchain will be hidden in the implementation.
> So the work that's left is creating this common interface and then making these two problem classes use it.
> 
> Using this new system is fairly straightforward.
> See the test plugin that I've created to test with:
> https://bitbucket.org/dfighter1985/kdev-problemtest/src
> 
> Especially widget.cpp which instantiates the model, and adds problems, or clears them based on which button is clicked.
> 
> 
> Here's a class diagram about all this:
> http://i.imgur.com/eGWR3sO.jpg
> 
> 
> Diffs
> -----
> 
>   interfaces/CMakeLists.txt 11fa364 
>   interfaces/ilanguagecontroller.h d76284c 
>   interfaces/iproblem.h PRE-CREATION 
>   language/codegen/templateengine_p.h fcb5a06 
>   language/duchain/navigation/problemnavigationcontext.h f19aa18 
>   language/duchain/navigation/problemnavigationcontext.cpp 99e2fd0 
>   language/duchain/problem.h eb3951a 
>   language/duchain/problem.cpp 8cbf45b 
>   plugins/problemreporter/CMakeLists.txt 39b3643 
>   plugins/problemreporter/problemhighlighter.h 1df7a79 
>   plugins/problemreporter/problemhighlighter.cpp b4a6ad2 
>   plugins/problemreporter/problemmodel.h 0d7d773 
>   plugins/problemreporter/problemmodel.cpp 9043a24 
>   plugins/problemreporter/problemreportermodel.h PRE-CREATION 
>   plugins/problemreporter/problemreportermodel.cpp PRE-CREATION 
>   plugins/problemreporter/problemreporterplugin.h 5afd8ad 
>   plugins/problemreporter/problemreporterplugin.cpp 5ca0c8d 
>   plugins/problemreporter/problemsview.h PRE-CREATION 
>   plugins/problemreporter/problemsview.cpp PRE-CREATION 
>   plugins/problemreporter/problemtreeview.h b9247d4 
>   plugins/problemreporter/problemtreeview.cpp 1c42034 
>   plugins/problemreporter/watcheddocumentset.h 9dda54d 
>   plugins/problemreporter/watcheddocumentset.cpp 143ee58 
>   shell/CMakeLists.txt cffa161 
>   shell/filteredproblemstore.h PRE-CREATION 
>   shell/filteredproblemstore.cpp PRE-CREATION 
>   shell/languagecontroller.h b9a3d06 
>   shell/languagecontroller.cpp d15a14b 
>   shell/problem.h PRE-CREATION 
>   shell/problem.cpp PRE-CREATION 
>   shell/problemmodel.h PRE-CREATION 
>   shell/problemmodel.cpp PRE-CREATION 
>   shell/problemmodelset.h PRE-CREATION 
>   shell/problemmodelset.cpp PRE-CREATION 
>   shell/problemstore.h PRE-CREATION 
>   shell/problemstore.cpp PRE-CREATION 
>   shell/problemstorenode.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124123/diff/
> 
> 
> Testing
> -------
> 
> See the included video.
> 
> 
> Thanks,
> 
> Laszlo Kis-Adam
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150628/4baa649c/attachment.html>