Review Request 124200: First bits of refactorings. Skeleton of interface for KDevelop. Build system (really nasty). CompilationDatabase for CMake projects and ClangTool (with cache, but without cache updates). Interface is not fixed for now.

Maciej Poleski d82ks8djf82msd83hf8sc02lqb5gh5 at
Sat Jun 27 21:44:14 UTC 2015

This is an automatically generated e-mail. To reply, visit:

Review request for KDevelop.

Repository: kdev-clang


Introduced rename variable refactoring.

This patch provides preliminary support for variable rename refactoring.
Currently only one project is supported.
Currently it is required to save all opened documents (cache is not ready).
Regeneration of compile_commands.json needs to be polished. How to get appropriate notification (IProjectBuilder::configured signal)? As a workaround i simply restarted KDevelop to get this regenerated.
To use this refactoring right click on variable declaration (definition) and select "rename" refactoring.

Full renaming support will consist of a few parts - one of them is renaming around VarDecl (this patch).
Quite early, but i wanted to see that this work is going into some direction after month of coding of pure interfaces/details.

How to split diffs? I noticed that RBTool created diff consisting of all changes ignoring other pending request. I wanted only the last one, because earlier commits are subject of other review.


  .reviewboardrc cd1ef2aa08623d813c80b5c5275b2ad0e35ff40e 
  CMakeLists.txt 875172a8407f4bd9faf330f032a280fa66c2b16f 
  clangsupport.h 8ed1ec90bbbc41d7c7a94d926e0951c729a6194c 
  clangsupport.cpp e22c55426a2e839ec11cbe0b2fe1e13721b0583a 
  cmake/FindClang.cmake 6c9bd6ef0242319122dcc7e6fd6cea8d9f0cbfbb 
  refactoring/CMakeLists.txt PRE-CREATION 
  refactoring/documentcache.h PRE-CREATION 
  refactoring/documentcache.cpp PRE-CREATION 
  refactoring/interface.h PRE-CREATION 
  refactoring/interface.cpp PRE-CREATION 
  refactoring/kdevrefactorings.h PRE-CREATION 
  refactoring/kdevrefactorings.cpp PRE-CREATION 
  refactoring/kdevrefactorings_disabled.h PRE-CREATION 
  refactoring/nooprefactoring.h PRE-CREATION 
  refactoring/nooprefactoring.cpp PRE-CREATION 
  refactoring/refactoring.h PRE-CREATION 
  refactoring/refactoring.cpp PRE-CREATION 
  refactoring/refactoringinfo.h PRE-CREATION 
  refactoring/refactoringinfo.cpp PRE-CREATION 
  refactoring/renamevardeclrefactoring.h PRE-CREATION 
  refactoring/renamevardeclrefactoring.cpp PRE-CREATION 
  refactoring/utils.h PRE-CREATION 
  refactoring/utils.cpp PRE-CREATION 



Manual testing on very small code bases as cache and compile_commands.json regeneration is not fully functional.


Maciej Poleski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list