Review Request 124003: Speed up grep output view

[Milian Wolff]

> On June 4, 2015, 12:14 p.m., Milian Wolff wrote:
> > Ship It!
> 
> Milian Wolff wrote:
>     Ping, any update on this? Do you have commit rights or do you want me to push this change for you?
> 
> Oleksandr Senkovych wrote:
>     Kevin asked to see if there is possibility to backport this changes to 4.x branch, and said that in future katepart grep output widget will be used. But personally I guess it will be no harm to apply it to master until switch to katepart will happen.

I agree - do you have commit rights or should we handle it for you?


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124003/#review81179
-----------------------------------------------------------


On June 4, 2015, 11:11 a.m., Oleksandr Senkovych wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124003/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 11:11 a.m.)
> 
> 
> Review request for KDevelop and Kevin Funk.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Grep output view is very laggy if there is a lot of items. For example on my machine adding just 300 items to this view takes about 10 seconds and whole KDevelop UI becomes unresponsive. After applying proposed changes there is no problem to add even 10 000 items - everything works without any lag. 
> Also, I didn't notice any regression in the UI: all rows in the view are displayed properly.
> 
> 
> Diffs
> -----
> 
>   plugins/grepview/grepoutputview.h 5191c58 
>   plugins/grepview/grepoutputview.cpp 2fba779 
>   plugins/grepview/grepviewplugin.h 29a4011 
>   plugins/grepview/grepviewplugin.cpp 4226302 
> 
> Diff: https://git.reviewboard.kde.org/r/124003/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Oleksandr Senkovych
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150623/46e3cd41/attachment.html>