Review Request 123963: First bits of refactorings. Skeleton of interface for KDevelop. Build system. CompilationDatabase for CMake projects and ClangTool.

[Maciej Poleski]

> On Cze 22, 2015, 9:54 po południu, Milian Wolff wrote:
> > clangsupport.cpp, line 232
> > <https://git.reviewboard.kde.org/r/123963/diff/5/?file=380721#file380721line232>
> >
> >     missing a compile guard. in general - is there any way to write this code _without_ the compile guard?

Compile guard can be moved elsewhere (to `RefactoringsGlue` making its implementation empty if not enabled (it's not the cleanest solution)). Write code without compile guard at all? We have to decide somehow if we have refactorings available. We have two main points in which this can be decided:
1. Compile time - in form of compile guards if we are going to link this code together (guarding from _any_ use of Clang - such use would require libTooling on compilation)
2. Run time - in form of `dlopen`/`dlsym` if we are not going to link this code together (replacing compile time guards with run time guards in form of `if(...)` or something similar)


> On Cze 22, 2015, 9:54 po południu, Milian Wolff wrote:
> > refactoring/CMakeLists.txt, line 16
> > <https://git.reviewboard.kde.org/r/123963/diff/5/?file=380723#file380723line16>
> >
> >     ? we already use clang for language support

Language support for codebase of kdev-clang, not codebase of project opened in KDevelop. If we already require some "special" compiler (with, as for now, "special" capabilities) - we could take adwantage of this without lose in portability.
We could simply build kdev-clang using Clang (which in any case is required). But that's an idea for future, not today.


- Maciej


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123963/#review81669
-----------------------------------------------------------


On Cze 20, 2015, 11:26 po południu, Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123963/
> -----------------------------------------------------------
> 
> (Updated Cze 20, 2015, 11:26 po południu)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> First bits of refactorings.
> Skeleton of interface for KDevelop.
> Build system (really nasty, linked DSO has 18MiB).
> CompilationDatabase for CMake projects and ClangTool (with cache, but without cache updates).
> Interface is not frozen for now.
> 
> Currently building of refactorings is enabled only if Clang 3.6.x is found. In other case build system behaves exactly as current master.
> 
> Refactorings require some contextual informations about projects. I made draft of interface with should feature:
>  - Stable ABI - dlopen (or equivalent) a DSO and if succeed (binary is still compatible with Clang libraries ABI), dlsym (or equivalent) some functions which are to provide all refactorings features
>  - Prototypes (with some implementation) of functions constituting API between KDevelop and refactorings backend
>  - It may be considered to use Qt plugin system to provide implementation of this (or equivalent) interface. This would be more expensive, but also more portable
>  - In worst case this library (static version) can be used with additional driver to make stand-alone executable providing all refactorings features (but it would require additional marshaling and hamper cooperation with user (how to provide UI in such a case?))
> 
> Handling dependencies between Clang/LLVM libraries is a nightmare. I extended FindClang.cmake to find much more libraries and used them to link with first pieces of my code. This is huge, requires additional libraries like zlib and even ordering of dependencies can cause linker errors.
> 
> Interface is not finished
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 875172a8407f4bd9faf330f032a280fa66c2b16f 
>   clangsupport.h 8ed1ec90bbbc41d7c7a94d926e0951c729a6194c 
>   clangsupport.cpp e22c55426a2e839ec11cbe0b2fe1e13721b0583a 
>   cmake/FindClang.cmake 6c9bd6ef0242319122dcc7e6fd6cea8d9f0cbfbb 
>   refactoring/CMakeLists.txt PRE-CREATION 
>   refactoring/DocumentCache.h PRE-CREATION 
>   refactoring/DocumentCache.cpp PRE-CREATION 
>   refactoring/NoopRefactoring.h PRE-CREATION 
>   refactoring/NoopRefactoring.cpp PRE-CREATION 
>   refactoring/Refactoring.h PRE-CREATION 
>   refactoring/Refactoring.cpp PRE-CREATION 
>   refactoring/RefactoringInfo.h PRE-CREATION 
>   refactoring/RefactoringInfo.cpp PRE-CREATION 
>   refactoring/RefactoringsGlue.h PRE-CREATION 
>   refactoring/RefactoringsGlue.cpp PRE-CREATION 
>   refactoring/interface.h PRE-CREATION 
>   refactoring/interface.cpp PRE-CREATION 
>   refactoring/utils.h PRE-CREATION 
>   refactoring/utils.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123963/diff/
> 
> 
> Testing
> -------
> 
> Compiles on my Gentoo system. It makes sense to build this only on system with Clang 3.6.
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150622/2dced6b6/attachment-0001.html>