Re: Review Request 124126: Referencies used on temporary object IndexedString modifié : cppduchain/cpppreprocessenvironment.cpp

[Milian Wolff]

> On June 19, 2015, 4:50 p.m., Aleix Pol Gonzalez wrote:
> > Hi,
> > What are you trying to achieve?
> 
> Milian Wolff wrote:
>     He wants to remove a compiler warning.
> 
> Sébastien Lambert wrote:
>     I found a very bag bug. 
>     When I load my project with the current master, cpp analyse crash on this line.
>     After analyse I found that call ref function is not correct with IndexString because IndexString::fromIndex return a local variable
> 
> Milian Wolff wrote:
>     ah so that is the reason for this crash? nice! means the optimizers got better! the code currently exhibits undefined-behavior by returning a reference-to-temporary, so crashing is perfectly fine :) please commit this patch! and add the following lines to your commit message:
>     
>         REVIEW: 124126
>         BUG: 347178
>     
>     also, if possible, please push this code into the 4.7 branch and I'll forward-merge it then. Or tell me, and I'll do all of the above for you.

I'll push this change for you now.


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124126/#review81570
-----------------------------------------------------------


On June 19, 2015, 7:47 a.m., Sébastien Lambert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124126/
> -----------------------------------------------------------
> 
> (Updated June 19, 2015, 7:47 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Use of references of local local object IndexedString 	modifié :         cppduchain/cpppreprocessenvironment.cpp
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cppduchain/cpppreprocessenvironment.cpp 6727e74f2c3f043952625a524de6d74e84b32892 
> 
> Diff: https://git.reviewboard.kde.org/r/124126/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sébastien Lambert
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150622/aa0f4108/attachment.html>