Review Request 124139: Added clang settings pages

[Aleix Pol Gonzalez]

> On June 21, 2015, 4:19 p.m., Alex Richardson wrote:
> > Does it really make sense to disable the override/implement completion? I guess for macros it can make sense since they increase the number of completion items a lot, but override and implement seems to me like it should always be included.

+1


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124139/#review81617
-----------------------------------------------------------


On June 21, 2015, 10:09 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124139/
> -----------------------------------------------------------
> 
> (Updated June 21, 2015, 10:09 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> This adds two pages: One for session settings (code-completion, assistants), another one for project settings (parser command-line arguments).
> 
> Known issue: now we can set language standard in two places: DaIM - for deducing standard macros/includes and here - for the internal parser.
> To solve this problem we can copy/move compilers infrastructure to kdev-clang. Also we can expose the compiler provider interface through DaIM (which is a much better solution imo). Suggestions?
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 875172a 
>   clangparsejob.cpp bea4fc0 
>   clangsettings/CMakeLists.txt PRE-CREATION 
>   clangsettings/clangconfigpage.h PRE-CREATION 
>   clangsettings/clangconfigpage.cpp PRE-CREATION 
>   clangsettings/clangprojectconfig.kcfg PRE-CREATION 
>   clangsettings/clangprojectconfig.kcfgc PRE-CREATION 
>   clangsettings/clangsettingsmanager.h PRE-CREATION 
>   clangsettings/clangsettingsmanager.cpp PRE-CREATION 
>   clangsettings/clangsettingsplugin.h PRE-CREATION 
>   clangsettings/clangsettingsplugin.cpp PRE-CREATION 
>   clangsettings/configwidget.h PRE-CREATION 
>   clangsettings/configwidget.cpp PRE-CREATION 
>   clangsettings/configwidget.ui PRE-CREATION 
>   clangsettings/kdevclangsettings.json PRE-CREATION 
>   clangsettings/pathsmodel.h PRE-CREATION 
>   clangsettings/pathsmodel.cpp PRE-CREATION 
>   clangsettings/sessionsettings/sessionconfig.kcfg PRE-CREATION 
>   clangsettings/sessionsettings/sessionconfig.kcfgc PRE-CREATION 
>   clangsettings/sessionsettings/sessionconfigskeleton.h PRE-CREATION 
>   clangsettings/sessionsettings/sessionsettings.h PRE-CREATION 
>   clangsettings/sessionsettings/sessionsettings.cpp PRE-CREATION 
>   clangsettings/sessionsettings/sessionsettings.ui PRE-CREATION 
>   codecompletion/context.cpp f26921f 
>   codegen/adaptsignatureassistant.cpp 2cdd34b 
>   duchain/CMakeLists.txt e07ef70 
>   duchain/clangparsingenvironment.h 2e4ea8b 
>   duchain/clangparsingenvironment.cpp 20a2dbf 
>   duchain/parsesession.h 74999de 
>   duchain/parsesession.cpp 563d227 
>   duchain/unknowndeclarationproblem.cpp 908a518 
> 
> Diff: https://git.reviewboard.kde.org/r/124139/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> session settings.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/21/fa06103b-17e0-453f-a4a5-5c3dd4183fd6__session_settings.png
> project settings.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/21/f4bb2220-dc63-478d-b423-f31434496afb__project_settings.png
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150621/12b37b8c/attachment.html>