Review Request 123963: First bits of refactorings. Skeleton of interface for KDevelop. Build system. CompilationDatabase for CMake projects and ClangTool.

Maciej Poleski d82ks8djf82msd83hf8sc02lqb5gh5 at
Sat Jun 20 21:26:58 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated Cze 20, 2015, 11:26 po poĊ‚udniu)

Review request for KDevelop.


Introduction of RefactoringsGlue to maintain connection between KDevelop interfaces and refactorings interfaces

Repository: kdev-clang


First bits of refactorings.
Skeleton of interface for KDevelop.
Build system (really nasty, linked DSO has 18MiB).
CompilationDatabase for CMake projects and ClangTool (with cache, but without cache updates).
Interface is not frozen for now.

Currently building of refactorings is enabled only if Clang 3.6.x is found. In other case build system behaves exactly as current master.

Refactorings require some contextual informations about projects. I made draft of interface with should feature:
 - Stable ABI - dlopen (or equivalent) a DSO and if succeed (binary is still compatible with Clang libraries ABI), dlsym (or equivalent) some functions which are to provide all refactorings features
 - Prototypes (with some implementation) of functions constituting API between KDevelop and refactorings backend
 - It may be considered to use Qt plugin system to provide implementation of this (or equivalent) interface. This would be more expensive, but also more portable
 - In worst case this library (static version) can be used with additional driver to make stand-alone executable providing all refactorings features (but it would require additional marshaling and hamper cooperation with user (how to provide UI in such a case?))

Handling dependencies between Clang/LLVM libraries is a nightmare. I extended FindClang.cmake to find much more libraries and used them to link with first pieces of my code. This is huge, requires additional libraries like zlib and even ordering of dependencies can cause linker errors.

Interface is not finished

Diffs (updated)

  CMakeLists.txt 875172a8407f4bd9faf330f032a280fa66c2b16f 
  clangsupport.h 8ed1ec90bbbc41d7c7a94d926e0951c729a6194c 
  clangsupport.cpp e22c55426a2e839ec11cbe0b2fe1e13721b0583a 
  cmake/FindClang.cmake 6c9bd6ef0242319122dcc7e6fd6cea8d9f0cbfbb 
  refactoring/CMakeLists.txt PRE-CREATION 
  refactoring/DocumentCache.h PRE-CREATION 
  refactoring/DocumentCache.cpp PRE-CREATION 
  refactoring/NoopRefactoring.h PRE-CREATION 
  refactoring/NoopRefactoring.cpp PRE-CREATION 
  refactoring/Refactoring.h PRE-CREATION 
  refactoring/Refactoring.cpp PRE-CREATION 
  refactoring/RefactoringInfo.h PRE-CREATION 
  refactoring/RefactoringInfo.cpp PRE-CREATION 
  refactoring/RefactoringsGlue.h PRE-CREATION 
  refactoring/RefactoringsGlue.cpp PRE-CREATION 
  refactoring/interface.h PRE-CREATION 
  refactoring/interface.cpp PRE-CREATION 
  refactoring/utils.h PRE-CREATION 
  refactoring/utils.cpp PRE-CREATION 



Compiles on my Gentoo system. It makes sense to build this only on system with Clang 3.6.


Maciej Poleski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list