Review Request 124007: Don't add functions for code-completion based on parameters.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124007/#review81198
-----------------------------------------------------------


generally +1, just two questions on my side


codecompletion/context.cpp (line 179)
<https://git.reviewboard.kde.org/r/124007/#comment55596>

    could this code maybe moved into CodeCompletion<NormalDeclarationCompletionItem>::data to share it with the other language plugins?



codecompletion/context.cpp (line 180)
<https://git.reviewboard.kde.org/r/124007/#comment55595>

    is the duchain locked here? or do we have to lock it? are you building kdevplatform in debug mode with assertions enabled?


- Milian Wolff


On June 4, 2015, 5:50 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124007/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 5:50 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> E.g.: class Abc; int f(Abc){ Ab|
> Completion invoked at the "|", that gives us "Abc" as a completion result. Before this we had "Abc" and "f(Abc)", which is obviously wrong.
>   
> Also this makes the "Detailed completion" option work.
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.cpp 87461f8 
>   tests/test_codecompletion.cpp d0fe3a7 
> 
> Diff: https://git.reviewboard.kde.org/r/124007/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150604/e44dbc79/attachment-0001.html>