Review Request 124001: Attach correct declarations for overloaded code-completion items

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124001/#review81160
-----------------------------------------------------------



codecompletion/context.cpp (line 606)
<https://git.reviewboard.kde.org/r/124001/#comment55568>

    this code and the one below should better be put into a free function to easen the understanding of the code.
    
    furthermore, ::values() is really slow, as it needs to allocate a list of return values. Rather, try to iterate directly over the hash (which is still slow, but better), and then return the found declaration. as a fallback, if nothing is found, use ctx->findDeclarations and then return a match there. if still nothing is found, return nullptr.


- Milian Wolff


On June 4, 2015, 9 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124001/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 9 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Now function signature in completion item matches declaration signature.
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.cpp 87461f8 
>   tests/test_codecompletion.h c13d4cc 
>   tests/test_codecompletion.cpp d0fe3a7 
> 
> Diff: https://git.reviewboard.kde.org/r/124001/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150604/6a6f8897/attachment.html>