Review Request 123963: First bits of refactorings. Skeleton of interface for KDevelop. Build system. CompilationDatabase for CMake projects and ClangTool.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123963/#review81135
-----------------------------------------------------------



refactoring/CMakeLists.txt (line 93)
<https://git.reviewboard.kde.org/r/123963/#comment55542>

    Is this really required? the libs above, are they shared or static? shared libs come with dependencies, and linking to ones own dependency is sufficient and will pull in all of its dependencies. So I really wonder why you need all of this. Maybe b/c you have only static versions of libtooling around?



refactoring/interface.h (line 1)
<https://git.reviewboard.kde.org/r/123963/#comment55544>

    here and below: all new files need license headers



refactoring/interface.h (line 56)
<https://git.reviewboard.kde.org/r/123963/#comment55543>

    there is also CXCompilationDataBase.h in clang-c - can that be used instead here?



refactoring/interface.cpp (line 22)
<https://git.reviewboard.kde.org/r/123963/#comment55548>

    I'd change the API, it should take a path to a compilation database file. it will be the same for code for cmake, qmake, xyz - always a compile_commands.json file in the $buildpath - no? or why is the ProjectKind required? If that file does not exist, return a nullptr.



refactoring/interface.cpp (line 46)
<https://git.reviewboard.kde.org/r/123963/#comment55546>

    dead code - remove? or will this be where you are going to implement things?
    
    also, do you _really_ want to take cache by rvalue ref? I doubt that. take it by value.



refactoring/interface.cpp (line 50)
<https://git.reviewboard.kde.org/r/123963/#comment55547>

    return by value


- Milian Wolff


On May 31, 2015, 11:56 a.m., Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123963/
> -----------------------------------------------------------
> 
> (Updated May 31, 2015, 11:56 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> First bits of refactorings.
> Skeleton of interface for KDevelop.
> Build system (really nasty, linked DSO has 18MiB).
> CompilationDatabase for CMake projects and ClangTool (with cache, but without cache updates).
> Interface is not frozen for now.
> 
> Currently building of refactorings is enabled only if Clang 3.6.x is found. In other case build system behaves exactly as current master.
> 
> Refactorings require some contextual informations about projects. I made draft of interface with should feature:
>  - Stable ABI - dlopen (or equivalent) a DSO and if succeed (binary is still compatible with Clang libraries ABI), dlsym (or equivalent) some functions which are to provide all refactorings features
>  - Prototypes (with some implementation) of functions constituting API between KDevelop and refactorings backend
>  - It may be considered to use Qt plugin system to provide implementation of this (or equivalent) interface. This would be more expensive, but also more portable
>  - In worst case this library (static version) can be used with additional driver to make stand-alone executable providing all refactorings features (but it would require additional marshaling and hamper cooperation with user (how to provide UI in such a case?))
> 
> Handling dependencies between Clang/LLVM libraries is a nightmare. I extended FindClang.cmake to find much more libraries and used them to link with first pieces of my code. This is huge, requires additional libraries like zlib and even ordering of dependencies can cause linker errors.
> 
> Interface is not finished
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 875172a8407f4bd9faf330f032a280fa66c2b16f 
>   cmake/FindClang.cmake 6c9bd6ef0242319122dcc7e6fd6cea8d9f0cbfbb 
>   refactoring/CMakeLists.txt PRE-CREATION 
>   refactoring/interface.h PRE-CREATION 
>   refactoring/interface.cpp PRE-CREATION 
>   refactoring/utils.h PRE-CREATION 
>   refactoring/utils.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123963/diff/
> 
> 
> Testing
> -------
> 
> Compiles on my Gentoo system. It makes sense to build this only on system with Clang 3.6.
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150603/c8e1fa76/attachment-0001.html>