Review Request 123987: Don't create declarations for anonymous function parameters

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123987/#review81098
-----------------------------------------------------------



duchain/builder.cpp (line 785)
<https://git.reviewboard.kde.org/r/123987/#comment55528>

    this is very costly for the common case of non-empty identifiers. could you instead use the range and check whether that is empty please? i.e. skip the string conversion


- Milian Wolff


On June 3, 2015, 7:04 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123987/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 7:04 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> E.g.: void f(int);
> The int parameter is anonymous, so instead of creting a declaration pointing at the ) we do nothing here.
> 
> 
> Diffs
> -----
> 
>   duchain/builder.cpp 4165cfc 
>   tests/files/variables.cpp 71935e9 
> 
> Diff: https://git.reviewboard.kde.org/r/123987/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150603/e49a816d/attachment-0001.html>