Review Request 123976: Fixed check for QGuiApplication during start of debug session

Aleix Pol Gonzalez aleixpol at kde.org
Mon Jun 1 17:32:43 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123976/#review81057
-----------------------------------------------------------


+1, how come I haven't hit this?

- Aleix Pol Gonzalez


On June 1, 2015, 6:54 p.m., Vladimir Novikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123976/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 6:54 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> qobject_cast should return not null in case if qApp is QGuiApplication. According qFatal text it should be null to produce an error.
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/debugsession.cpp fe015ae 
> 
> Diff: https://git.reviewboard.kde.org/r/123976/diff/
> 
> 
> Testing
> -------
> 
> Debugger starts in kdevelop session, not crashing with "You need a graphical application." error.
> 
> 
> Thanks,
> 
> Vladimir Novikov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150601/f03df3ba/attachment.html>


More information about the KDevelop-devel mailing list