Review Request 123962: Add support for the goto statement

[Olivier Jean de Gaalon]

> On June 1, 2015, 7:10 a.m., Kevin Funk wrote:
> > tests/files/goto.cpp, line 3
> > <https://git.reviewboard.kde.org/r/123962/diff/2/?file=378505#file378505line3>
> >
> >     +1. This look odd.
> >     
> >     clang-parse says that `goto label;` is a use of the label statement, so it should be indeed the other way around.
> >     
> >     ```
> >     FunctionDecl (8) | type: "int ()" (111) | display: "main()" | loc: test.cpp@[(1,1),(7,2)] | isDecl
> >       CompoundStmt (202) | loc: test.cpp@[(1,12),(7,2)] 
> >         GotoStmt (210) | loc: test.cpp@[(3,5),(3,15)] | isUse
> >           LabelRef (48) | display: "label" | loc: test.cpp@[(3,10),(3,15)] | isUse
> >         LabelStmt (201) | display: "label" | loc: test.cpp@[(5,1),(6,13)] 
> >           ReturnStmt (214) | loc: test.cpp@[(6,5),(6,13)] 
> >             IntegerLiteral (106) | type: "int" (17) | loc: test.cpp@[(6,12),(6,13)]
> >     ```

Ah, this is an issue with JSON tests... if you add a comment that's not attached to a declaration, you get no indication that something is wrong, and the test is never actually run/evaluated.


- Olivier Jean de


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123962/#review81033
-----------------------------------------------------------


On May 31, 2015, 5:18 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123962/
> -----------------------------------------------------------
> 
> (Updated May 31, 2015, 5:18 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Add support for the goto statement
> 
> 
> Diffs
> -----
> 
>   duchain/builder.cpp 0acde9a 
>   duchain/cursorkindtraits.h a623861 
>   tests/files/goto.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123962/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150601/45a42fef/attachment-0001.html>