Review Request 123962: Add support for the goto statement

[Olivier Jean de Gaalon]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123962/#review81029
-----------------------------------------------------------


On second thought, maybe the DelayedType should use the actual label text. Not very important, your call.
It would be nice to include a second "goto label" in the test, at least so we can document the strangeness of this.


tests/files/goto.cpp (line 3)
<https://git.reviewboard.kde.org/r/123962/#comment55489>

    This is confusing: The "goto foo" line is a declaration and the "foo:" line is a use?
    
    It seems like it should be the other way around... what happens when there are multiple "goto foo" calls?
    
    I guess this is Clang's doing, but I don't understand the logic here.


- Olivier Jean de Gaalon


On May 31, 2015, 5:18 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123962/
> -----------------------------------------------------------
> 
> (Updated May 31, 2015, 5:18 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Add support for the goto statement
> 
> 
> Diffs
> -----
> 
>   duchain/builder.cpp 0acde9a 
>   duchain/cursorkindtraits.h a623861 
>   tests/files/goto.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123962/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150601/04d67216/attachment.html>