Review Request 124426: Move populating of context menu to background

[Maciej Poleski]

> On Lip 30, 2015, 9:24 po południu, Milian Wolff wrote:
> > Puh, Maciej, lets do it - but this is extremely complex code. As I said before, I'd welcome if we could discuss the future of your GSOC. In my opinion, this is the wrong direction, and we should try to take a step back and see how we could get something more useful - albeit far simpler - out of the clang integration. Don't get me wrong, your contributions are all extremely valuable. It just looks to me as if libTooling is not a good match for integration into KDevelop in the current form.
> > 
> > As I said before, I'd like to see how we could implement "simple" local refactorings - probably without libTooling and just using the clang-c API. You could start with things like a de-inliner, i.e. similar to what we have in oldcpp (the "move to source" action).
> > 
> > Let's discuss this on our mailing list more, or better yet on IRC if possible. I'll continue to review your other patches now.
> > 
> > Cheers

I sent message "Future of refactorings" on mailing list. Take look at free time


- Maciej


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124426/#review83191
-----------------------------------------------------------


On Lip 27, 2015, 9:43 po południu, Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124426/
> -----------------------------------------------------------
> 
> (Updated Lip 27, 2015, 9:43 po południu)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Introduced worker thread for time-consuming Clang actions.
> 
> Moved populating of context menu (list of applicable refactorings) to background.
> 
> 
> Diffs
> -----
> 
>   refactoring/CMakeLists.txt PRE-CREATION 
>   refactoring/actionwatcher.h PRE-CREATION 
>   refactoring/actionwatcher.cpp PRE-CREATION 
>   refactoring/contextmenumutator.h PRE-CREATION 
>   refactoring/contextmenumutator.cpp PRE-CREATION 
>   refactoring/interface.h PRE-CREATION 
>   refactoring/interface.cpp PRE-CREATION 
>   refactoring/kdevrefactorings.h PRE-CREATION 
>   refactoring/kdevrefactorings.cpp PRE-CREATION 
>   refactoring/refactoringcontext.h PRE-CREATION 
>   refactoring/refactoringcontext.cpp PRE-CREATION 
>   refactoring/refactoringcontext_worker.h PRE-CREATION 
>   refactoring/refactoringcontext_worker.cpp PRE-CREATION 
>   refactoring/refactoringmanager.h PRE-CREATION 
>   refactoring/refactoringmanager.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124426/diff/
> 
> 
> Testing
> -------
> 
> Manual testing
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150731/a7967763/attachment.html>