Review Request 124502: This patch moves the class browser plugin's classmodel classes to libKDevPlatformLanguage.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124502/#review83234
-----------------------------------------------------------


The include directories schema was designed so that the includes didn't need to be changed whenever you move code within kdevplatform/kdevelop.


plugins/classbrowser/classmodel.cpp (line 30)
<https://git.reviewboard.kde.org/r/124502/#comment57475>

    Why did you change those?



plugins/classbrowser/classmodelnode.cpp (line 29)
<https://git.reviewboard.kde.org/r/124502/#comment57476>

    Why did you change those?


- Aleix Pol Gonzalez


On July 28, 2015, 1:26 p.m., Sandro Andrade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124502/
> -----------------------------------------------------------
> 
> (Updated July 28, 2015, 1:26 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This patch moves the class browser plugin's classmodel classes to libKDevPlatformLanguage. The reason is to allow such code to be reused by plugins that require information about the project's namespaces, classes, and methods. The kdev-bundled-tree-view plugin needs that information for implementing its visualization features.
> 
> 
> Diffs
> -----
> 
>   language/CMakeLists.txt 2c2b028 
>   plugins/classbrowser/CMakeLists.txt 9989a4c 
>   plugins/classbrowser/allclassesfolder.h 48544d2 
>   plugins/classbrowser/allclassesfolder.cpp 6b40a44 
>   plugins/classbrowser/classbrowserplugin.cpp 140ed7d 
>   plugins/classbrowser/classmodel.h c6f0d3a 
>   plugins/classbrowser/classmodel.cpp 4aff279 
>   plugins/classbrowser/classmodelnode.h b8c038c 
>   plugins/classbrowser/classmodelnode.cpp 5f8e449 
>   plugins/classbrowser/classmodelnodescontroller.h c139465 
>   plugins/classbrowser/classmodelnodescontroller.cpp a51baa2 
>   plugins/classbrowser/classtree.cpp c173e09 
>   plugins/classbrowser/classwidget.cpp 53d09ab 
>   plugins/classbrowser/documentclassesfolder.h 3fd30a4 
>   plugins/classbrowser/documentclassesfolder.cpp e05e365 
>   plugins/classbrowser/projectfolder.h accb9a6 
>   plugins/classbrowser/projectfolder.cpp 26834c1 
> 
> Diff: https://git.reviewboard.kde.org/r/124502/diff/
> 
> 
> Testing
> -------
> 
> It builds fine and everything looks similar as before when using the class browser plugin.
> 
> 
> Thanks,
> 
> Sandro Andrade
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150731/0141d4f7/attachment.html>