Review Request 124545: Add plural form for number of files for simplified parsing spinbox

Aleix Pol Gonzalez aleixpol at kde.org
Fri Jul 31 13:02:35 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124545/#review83233
-----------------------------------------------------------

Ship it!


Looks good to me, thanks a lot for the patch!

PS: Next time, you can add something in the testing field and maybe even a screenshot.

- Aleix Pol Gonzalez


On July 31, 2015, 1:38 p.m., Brais Arias Rio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124545/
> -----------------------------------------------------------
> 
> (Updated July 31, 2015, 1:38 p.m.)
> 
> 
> Review request for KDevelop, Albert Astals Cid and José Millán Soto.
> 
> 
> Bugs: 254331
>     http://bugs.kde.org/show_bug.cgi?id=254331
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Changed kcfg_minFilesForSimplifiedParsing from QSpinBox to KPluralHandlingSpinBox
> 
> 
> Diffs
> -----
> 
>   shell/settings/languagepreferences.cpp 544fce8 
>   shell/settings/languagepreferences.ui d093622 
> 
> Diff: https://git.reviewboard.kde.org/r/124545/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brais Arias Rio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150731/a6d5da40/attachment.html>


More information about the KDevelop-devel mailing list