Review Request 124529: Add configured signal to CMakeBuilder

[Maciej Poleski]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124529/
-----------------------------------------------------------

Review request for KDevelop and Milian Wolff.


Repository: kdevelop


Description
-------

Add configured signal to `CMakeBuilder` (from `IProjectBuilder`, missing?), connect configure result (`KJob::result`) with emitting `configured` signal


I was wondering if it is possible (with reasonable amount of work) to detect such changes in a project resulting in need to re-run configure step. Implementation of `CMakeBuilder` can decide if (re)configure is neccessary, but only on demand.

It seems that `moc` doesn't generate implementation of signals in `IProjectBuilder`... (`Q_OBJECT`/`QObject` required as a marker?) What is the reason for `Q_SIGNALS` section in definition of `IProjectBuilder`? (these are neccessarily dead in this situation)


Diffs
-----

  projectbuilders/cmakebuilder/cmakebuilder.h af2f97eb9b5fd3593c5daa98c82573df0f390aab 
  projectbuilders/cmakebuilder/cmakebuilder.cpp f2a3529d1577ab71d488b279371b8fd1d26344e9 

Diff: https://git.reviewboard.kde.org/r/124529/diff/


Testing
-------

Connected to new signal in kdev-clang (local), works as expected.

Note: kdev-clang is not building due to recent changes in KDevelop (some constructors are now explicit, two trivial fixes in kdev-clang are required to compile)


Thanks,

Maciej Poleski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150730/91daf08e/attachment.html>