Review Request 124513: Correctly build parent contexts for out-of-line methods

Milian Wolff mail at milianw.de
Tue Jul 28 17:17:03 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124513/#review83109
-----------------------------------------------------------

Ship it!



codecompletion/context.cpp (line 522)
<https://git.reviewboard.kde.org/r/124513/#comment57385>

    I would like to see this fixed properly in the duchain builder, if possible. I'm OK with pushing this as a workaround for now though!


- Milian Wolff


On July 28, 2015, 4:03 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124513/
> -----------------------------------------------------------
> 
> (Updated July 28, 2015, 4:03 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Use a helper context for that
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.cpp 61c36b8 
>   duchain/builder.cpp b3ed590 
>   tests/files/outofline.cpp 30e14f7 
>   tests/test_codecompletion.cpp c54206d 
> 
> Diff: https://git.reviewboard.kde.org/r/124513/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150728/a887745a/attachment-0001.html>


More information about the KDevelop-devel mailing list