Review Request 124426: Move populating of context menu to background

Maciej Poleski d82ks8djf82msd83hf8sc02lqb5gh5 at gmail.com
Mon Jul 27 19:43:27 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124426/
-----------------------------------------------------------

(Updated Lip 27, 2015, 9:43 po poĊ‚udniu)


Review request for KDevelop.


Changes
-------

Wrapped direct `QMetaObject::invoke` calls into `QTimer::singleShot`, signals/slots and auxilary callbacks

`schedule*` family of methods accept a *task* - computation to be performed in background, and a *callback* - function to be invoked in `RefactoringContext` thread with result of *task* as an argument

It doesn't seem to have simplified this thing...


Repository: kdev-clang


Description
-------

Introduced worker thread for time-consuming Clang actions.

Moved populating of context menu (list of applicable refactorings) to background.


Diffs (updated)
-----

  refactoring/CMakeLists.txt PRE-CREATION 
  refactoring/actionwatcher.h PRE-CREATION 
  refactoring/actionwatcher.cpp PRE-CREATION 
  refactoring/contextmenumutator.h PRE-CREATION 
  refactoring/contextmenumutator.cpp PRE-CREATION 
  refactoring/interface.h PRE-CREATION 
  refactoring/interface.cpp PRE-CREATION 
  refactoring/kdevrefactorings.h PRE-CREATION 
  refactoring/kdevrefactorings.cpp PRE-CREATION 
  refactoring/refactoringcontext.h PRE-CREATION 
  refactoring/refactoringcontext.cpp PRE-CREATION 
  refactoring/refactoringcontext_worker.h PRE-CREATION 
  refactoring/refactoringcontext_worker.cpp PRE-CREATION 
  refactoring/refactoringmanager.h PRE-CREATION 
  refactoring/refactoringmanager.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124426/diff/


Testing
-------

Manual testing


Thanks,

Maciej Poleski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150727/74ccaaec/attachment.html>


More information about the KDevelop-devel mailing list