Review Request 124420: Added toggle targets to project view to hide targets from the view.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124420/#review83012
-----------------------------------------------------------



plugins/projectmanagerview/projectmanagerview.cpp (line 102)
<https://git.reviewboard.kde.org/r/124420/#comment57312>

    It should be positive: "Show Targets"



plugins/projectmanagerview/projectmanagerview.cpp (line 222)
<https://git.reviewboard.kde.org/r/124420/#comment57311>

    Maybe the debug isn't really needed? or at least turn into qCDebug.



project/projectproxymodel.cpp (line 48)
<https://git.reviewboard.kde.org/r/124420/#comment57310>

    Maybe the debug isn't really needed? or at least turn into qCDebug.



project/projectproxymodel.cpp (line 63)
<https://git.reviewboard.kde.org/r/124420/#comment57309>

    Maybe the debug isn't really needed? or at least turn into qCDebug.


Small issues, ready to go in.

- Aleix Pol Gonzalez


On July 26, 2015, 4:11 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124420/
> -----------------------------------------------------------
> 
> (Updated July 26, 2015, 4:11 p.m.)
> 
> 
> Review request for KDevelop, Aleix Pol Gonzalez and Kevin Funk.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Added toggle targets to project view to hide targets from the view.
> 
> 
> Diffs
> -----
> 
>   plugins/projectmanagerview/projectmanagerview.h 57774ffac08219605b4e630ad2199315e84999ef 
>   plugins/projectmanagerview/projectmanagerview.cpp dcf4d34ba1037704a49f6d76b10b5cb0ee223a45 
>   project/projectproxymodel.h 51ae1680a4dbd506d3e25a88f218f6c891f9f16d 
>   project/projectproxymodel.cpp 995c29b200f3897723627c891cc848107cebc513 
> 
> Diff: https://git.reviewboard.kde.org/r/124420/diff/
> 
> 
> Testing
> -------
> 
> Button works and hides/shows targets in the Project pane.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150727/822f9d03/attachment.html>