Review Request 124369: Encapsulate field refactoring

[Maciej Poleski]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124369/
-----------------------------------------------------------

(Updated Lip 27, 2015, 12:24 rano)


Review request for KDevelop.


Changes
-------

second try to publish image


Repository: kdev-clang


Description
-------

Encapsulate field refactoring

- Displays dialog
- Transforms "use" site - replaces direct uses of encapsulated variable by calls to getter and setter method/function.
- Generates getter and setter implementation

Attached image presents GUI with its default content (prefilled by heuristics on DeclaratorDecl AST node).


Diffs
-----

  refactoring/CMakeLists.txt PRE-CREATION 
  refactoring/encapsulatefielddialog.h PRE-CREATION 
  refactoring/encapsulatefielddialog.cpp PRE-CREATION 
  refactoring/encapsulatefielddialog.ui PRE-CREATION 
  refactoring/encapsulatefieldrefactoring.h PRE-CREATION 
  refactoring/encapsulatefieldrefactoring.cpp PRE-CREATION 
  refactoring/encapsulatefieldrefactoring_changepack.h PRE-CREATION 
  refactoring/encapsulatefieldrefactoring_changepack.cpp PRE-CREATION 
  refactoring/redeclarationchain.cpp PRE-CREATION 
  refactoring/refactoringmanager.cpp PRE-CREATION 
  refactoring/tudecldispatcher.h PRE-CREATION 
  refactoring/tudecldispatcher.cpp PRE-CREATION 
  refactoring/utils.h PRE-CREATION 
  refactoring/utils.cpp PRE-CREATION 
  tests/CMakeLists.txt 20d17efae9a2a77cd7ef76bf7484ccfcf12e4cd8 
  tests/test_encapsulatefield.h PRE-CREATION 
  tests/test_encapsulatefield.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124369/diff/


Testing
-------

Manual testing, unit testing


File Attachments (updated)
----------------

Encapsulate field dialog
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/15/ea15c55b-cc4d-4dfa-ac34-8c568a93701d__snapshot3.png
Encapsulate field dialog 2
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/26/1b0f52de-b1b3-4a70-8c90-67abec650733__snapshot4.png
Encapsulate field dialog 2 (second try)
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/26/f6e56312-07e2-4563-a579-77c0eca6c877__snapshot7.png


Thanks,

Maciej Poleski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150726/121c3683/attachment.html>