Review Request 124300: Change signature

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124300/#review82979
-----------------------------------------------------------

Ship it!


minor stuff on my side. I have to admit that the code becomes hard to grasp for me though, I really need to start to try out your code to give you better feedback, I think.


refactoring/changesignaturedialog.cpp (line 27)
<https://git.reviewboard.kde.org/r/124300/#comment57267>

    just include <KLocalizedString>



refactoring/changesignaturedialog.cpp (lines 201 - 202)
<https://git.reviewboard.kde.org/r/124300/#comment57268>

    I suggest you introduce an `enum Columns` to the model with `Type` and `Name` enumerators and use them here instead of magic numbers.



refactoring/changesignaturedialog.cpp (line 216)
<https://git.reviewboard.kde.org/r/124300/#comment57269>

    same



refactoring/changesignaturedialog.cpp (line 251)
<https://git.reviewboard.kde.org/r/124300/#comment57270>

    same



refactoring/changesignaturedialog.cpp (line 276)
<https://git.reviewboard.kde.org/r/124300/#comment57271>

    what do you mean by leak here? not memory, I guess?



refactoring/changesignaturerefactoring.cpp (line 82)
<https://git.reviewboard.kde.org/r/124300/#comment57272>

    align please, also below and elsewhere



refactoring/utils.cpp (line 352)
<https://git.reviewboard.kde.org/r/124300/#comment57273>

    Q_ASSERT?


- Milian Wolff


On July 13, 2015, 9:34 p.m., Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124300/
> -----------------------------------------------------------
> 
> (Updated July 13, 2015, 9:34 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Change signature refactoring
> 
> I decided not to implement rename function refactoring. Change signature will provide this functionality.
> We can rename all functions except constructors, destructors, conversion operators, operators.
> Operators must preserve number of parameters (imagine 2+2 and operator+).
> 
> This functionality allows to:
> - change return type
> - change function name
> - change parameter types (preserving identity, tracking of this is not perfect - we lose this information)
> - change order of parameters
> - introduce new parameters
> - remove existing parameters
> 
> Somewhere here should be screenshoot of this dialog...
> 
> 
> Diffs
> -----
> 
>   refactoring/CMakeLists.txt PRE-CREATION 
>   refactoring/changesignaturedialog.h PRE-CREATION 
>   refactoring/changesignaturedialog.cpp PRE-CREATION 
>   refactoring/changesignaturedialog.ui PRE-CREATION 
>   refactoring/changesignaturerefactoring.h PRE-CREATION 
>   refactoring/changesignaturerefactoring.cpp PRE-CREATION 
>   refactoring/changesignaturerefactoringchangepack.h PRE-CREATION 
>   refactoring/changesignaturerefactoringchangepack.cpp PRE-CREATION 
>   refactoring/changesignaturerefactoringinfopack.h PRE-CREATION 
>   refactoring/changesignaturerefactoringinfopack.cpp PRE-CREATION 
>   refactoring/debug.h PRE-CREATION 
>   refactoring/refactoring.h PRE-CREATION 
>   refactoring/refactoring.cpp PRE-CREATION 
>   refactoring/refactoringmanager.cpp PRE-CREATION 
>   refactoring/utils.h PRE-CREATION 
>   refactoring/utils.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124300/diff/
> 
> 
> Testing
> -------
> 
> Manual testing of GUI. No transformation tests yet...
> 
> 
> File Attachments
> ----------------
> 
> snapshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/08/e8a8db09-92f9-4fb6-ac4a-3ab2a5051033__snapshot1.png
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150726/a93ec9c5/attachment.html>