Review Request 124445: Show Memcheck issues in the problems toolview

Laszlo Kis-Adam dfighter1985 at gmail.com
Sat Jul 25 19:04:08 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124445/
-----------------------------------------------------------

(Updated July 25, 2015, 9:04 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Repository: kdev-valgrind


Description
-------

Memcheck is one of the Valgrind tools supported by kdev-valgrind.
The issues found by that tool will now be shown in the problems toolview, in the "Valgrind" tab, instead of it's own widget.
Therefore I removed the custom model and widget as well.

See screenshot:
http://i.imgur.com/xxFBnmu.jpg

The rest of the tools are not problem checkers and their output doesn't fit into the problems toolview, so the valgrind toolview, and the rest of the custom models and views will have to stay.


Diffs
-----

  CMakeLists.txt 7aeace1 
  imodel.h 6b6a8a3 
  imodel.cpp fa838a6 
  job.cpp 865483e 
  marks.cpp 43c039d 
  models/memcheckfakemodel.h PRE-CREATION 
  models/memcheckfakemodel.cpp PRE-CREATION 
  models/memcheckitemsimpl.h 9d3d76a 
  models/memcheckitemsimpl.cpp adfc03e 
  models/memcheckmodel.h f8b8716 
  models/memcheckmodel.cpp f05e919 
  parsers/memcheckparser.h 0673ca9 
  parsers/memcheckparser.cpp 4a85074 
  plugin.h ebe3378 
  plugin.cpp cbcbdea 
  views/memcheckview.h 1c399f3 
  views/memcheckview.cpp f9201e3 
  widget.cpp ef44a45 

Diff: https://git.reviewboard.kde.org/r/124445/diff/


Testing
-------

* Builds
* Works as intended


Thanks,

Laszlo Kis-Adam

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150725/5a5d2ae1/attachment-0001.html>


More information about the KDevelop-devel mailing list