Review Request 124445: Show Memcheck issues in the problems toolview

[Laszlo Kis-Adam]

> On July 24, 2015, 11:25 a.m., Milian Wolff wrote:
> > models/memcheckfakemodel.h, line 43
> > <https://git.reviewboard.kde.org/r/124445/diff/1/?file=387126#file387126line43>
> >
> >     hacky ;-) but a good first step. could you clean it up now and remove the need for this hack?
> 
> Laszlo Kis-Adam wrote:
>     What exactly do you consider hacky here? Do you have a suggestion?
> 
> Milian Wolff wrote:
>     It implements some API without actually implementing it. That is code smell, and should be removed. If the interface is broken, remove it, or change it.

I've made the override optional, now that method return null by default.
Is it better this way?


- Laszlo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124445/#review82863
-----------------------------------------------------------


On July 24, 2015, 7:08 p.m., Laszlo Kis-Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124445/
> -----------------------------------------------------------
> 
> (Updated July 24, 2015, 7:08 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-valgrind
> 
> 
> Description
> -------
> 
> Memcheck is one of the Valgrind tools supported by kdev-valgrind.
> The issues found by that tool will now be shown in the problems toolview, in the "Valgrind" tab, instead of it's own widget.
> Therefore I removed the custom model and widget as well.
> 
> See screenshot:
> http://i.imgur.com/xxFBnmu.jpg
> 
> The rest of the tools are not problem checkers and their output doesn't fit into the problems toolview, so the valgrind toolview, and the rest of the custom models and views will have to stay.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7aeace1 
>   imodel.h 6b6a8a3 
>   imodel.cpp fa838a6 
>   job.cpp 865483e 
>   marks.cpp 43c039d 
>   models/memcheckfakemodel.h PRE-CREATION 
>   models/memcheckfakemodel.cpp PRE-CREATION 
>   models/memcheckitemsimpl.h 9d3d76a 
>   models/memcheckitemsimpl.cpp adfc03e 
>   models/memcheckmodel.h f8b8716 
>   models/memcheckmodel.cpp f05e919 
>   parsers/memcheckparser.h 0673ca9 
>   parsers/memcheckparser.cpp 4a85074 
>   plugin.h ebe3378 
>   plugin.cpp cbcbdea 
>   views/memcheckview.h 1c399f3 
>   views/memcheckview.cpp f9201e3 
>   widget.cpp ef44a45 
> 
> Diff: https://git.reviewboard.kde.org/r/124445/diff/
> 
> 
> Testing
> -------
> 
> * Builds
> * Works as intended
> 
> 
> Thanks,
> 
> Laszlo Kis-Adam
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150724/aaa02fd0/attachment.html>