Review Request 124450: Restore std::move tests, revert part of cf48e4d26257b

[Boris Egorov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124450/
-----------------------------------------------------------

(Updated July 24, 2015, 4:47 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop, Kevin Funk and Milian Wolff.


Changes
-------

Submitted with commit 258f9ce801d709eb87a8ca611fcb513a8ab53c54 by Boris Egorov to branch master.


Repository: kdevplatform


Description
-------

Commit cf48e4d26257b removed tests of 'moved-from' values after
std::move. This commit restores these tests and make move constructors
non-explicit to pass tests. Behaviour of explicit move constructors
should be investigated later.

See https://git.reviewboard.kde.org/r/124427/

Note: there is one more move constructor which is still explicit:

explicit OutlineNode(OutlineNode&& other) noexcept;

There is no test for it, so change making them explicit was not reverted.
We should add a test for this constructor in the first order, IMHO.


Diffs
-----

  language/duchain/identifier.h 204f8e06ba4f73da49df3a971a90b84745a1712f 
  language/duchain/tests/test_identifier.cpp 0506fdbc999e5a14aaf8599376f4f84cb94affc4 
  serialization/indexedstring.h 4c8ed65d8c6fd0f8fa7bc1edab437d5ba15837d9 
  serialization/tests/test_indexedstring.cpp 19ce452567eefc4bc08ad3087a8dc15919a75fc9 

Diff: https://git.reviewboard.kde.org/r/124450/diff/


Testing
-------

Builds, passes tests


File Attachments
----------------

failed tests verbose log
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/24/f8fc5841-8203-421c-ac11-513d45fd97fc__kdevplatform_explicit_failed_tests.log


Thanks,

Boris Egorov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150724/0fca6635/attachment.html>