Review Request 124445: Show Memcheck issues in the problems toolview

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124445/#review82863
-----------------------------------------------------------



models/memcheckfakemodel.h (line 43)
<https://git.reviewboard.kde.org/r/124445/#comment57163>

    hacky ;-) but a good first step. could you clean it up now and remove the need for this hack?



models/memcheckfakemodel.cpp (line 19)
<https://git.reviewboard.kde.org/r/124445/#comment57168>

    remove the `./`



models/memcheckfakemodel.cpp (line 30)
<https://git.reviewboard.kde.org/r/124445/#comment57167>

    please add a `using namespace KDevelop;` and remove the `KDevelop::` qualification from the identifiers below



models/memcheckfakemodel.cpp (line 41)
<https://git.reviewboard.kde.org/r/124445/#comment57162>

    wrap in QLatin1String



models/memcheckfakemodel.cpp (line 150)
<https://git.reviewboard.kde.org/r/124445/#comment57165>

    !isEmpty()



models/memcheckfakemodel.cpp (line 153)
<https://git.reviewboard.kde.org/r/124445/#comment57166>

    const& the dp



models/memcheckfakemodel.cpp (line 178)
<https://git.reviewboard.kde.org/r/124445/#comment57164>

    use foreach


- Milian Wolff


On July 24, 2015, 12:20 a.m., Laszlo Kis-Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124445/
> -----------------------------------------------------------
> 
> (Updated July 24, 2015, 12:20 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-valgrind
> 
> 
> Description
> -------
> 
> Memcheck is one of the Valgrind tools supported by kdev-valgrind.
> The issues found by that tool will now be shown in the problems toolview, in the "Valgrind" tab, instead of it's own widget.
> Therefore I removed the custom model and widget as well.
> 
> See screenshot:
> http://i.imgur.com/xxFBnmu.jpg
> 
> The rest of the tools are not problem checkers and their output doesn't fit into the problems toolview, so the valgrind toolview, and the rest of the custom models and views will have to stay.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7aeace1 
>   job.cpp 865483e 
>   marks.cpp 43c039d 
>   models/memcheckfakemodel.h PRE-CREATION 
>   models/memcheckfakemodel.cpp PRE-CREATION 
>   models/memcheckitemsimpl.h 9d3d76a 
>   models/memcheckitemsimpl.cpp adfc03e 
>   models/memcheckmodel.h f8b8716 
>   models/memcheckmodel.cpp f05e919 
>   parsers/memcheckparser.h 0673ca9 
>   parsers/memcheckparser.cpp 4a85074 
>   plugin.h ebe3378 
>   plugin.cpp cbcbdea 
>   views/memcheckview.h 1c399f3 
>   views/memcheckview.cpp f9201e3 
>   widget.cpp ef44a45 
> 
> Diff: https://git.reviewboard.kde.org/r/124445/diff/
> 
> 
> Testing
> -------
> 
> * Builds
> * Works as intended
> 
> 
> Thanks,
> 
> Laszlo Kis-Adam
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150724/2137632d/attachment.html>