Review Request 124369: Encapsulate field refactoring

[Maciej Poleski]

> On Lip 21, 2015, 5:25 po południu, Milian Wolff wrote:
> > code looks good, can you show a screenshot of it in action? and can we get unit tests?

what kind of screenshot? UI?


> On Lip 21, 2015, 5:25 po południu, Milian Wolff wrote:
> > refactoring/encapsulatefieldrefactoring.cpp, line 361
> > <https://git.reviewboard.kde.org/r/124369/diff/3/?file=386449#file386449line361>
> >
> >     when can that happen? should it be handled gracefully?

never (unless someday enumeration will be extended)


> On Lip 21, 2015, 5:25 po południu, Milian Wolff wrote:
> > refactoring/encapsulatefieldrefactoring_changepack.cpp, line 42
> > <https://git.reviewboard.kde.org/r/124369/diff/3/?file=386451#file386451line42>
> >
> >     deindent by one space, to align the : and ,

i'm working on it


- Maciej


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124369/#review82768
-----------------------------------------------------------


On Lip 21, 2015, 11:22 po południu, Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124369/
> -----------------------------------------------------------
> 
> (Updated Lip 21, 2015, 11:22 po południu)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Encapsulate field refactoring
> 
> - Displays dialog
> - Transforms "use" site - replaces direct uses of encapsulated variable by calls to getter and setter method/function.
> - Generates getter and setter implementation
> 
> Attached image presents GUI with its default content (prefilled by heuristics on DeclaratorDecl AST node).
> 
> 
> Diffs
> -----
> 
>   refactoring/CMakeLists.txt PRE-CREATION 
>   refactoring/encapsulatefielddialog.h PRE-CREATION 
>   refactoring/encapsulatefielddialog.cpp PRE-CREATION 
>   refactoring/encapsulatefielddialog.ui PRE-CREATION 
>   refactoring/encapsulatefieldrefactoring.h PRE-CREATION 
>   refactoring/encapsulatefieldrefactoring.cpp PRE-CREATION 
>   refactoring/encapsulatefieldrefactoring_changepack.h PRE-CREATION 
>   refactoring/encapsulatefieldrefactoring_changepack.cpp PRE-CREATION 
>   refactoring/redeclarationchain.cpp PRE-CREATION 
>   refactoring/refactoringmanager.cpp PRE-CREATION 
>   refactoring/tudecldispatcher.h PRE-CREATION 
>   refactoring/tudecldispatcher.cpp PRE-CREATION 
>   refactoring/utils.h PRE-CREATION 
>   refactoring/utils.cpp PRE-CREATION 
>   tests/CMakeLists.txt 20d17efae9a2a77cd7ef76bf7484ccfcf12e4cd8 
>   tests/test_encapsulatefield.h PRE-CREATION 
>   tests/test_encapsulatefield.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124369/diff/
> 
> 
> Testing
> -------
> 
> Manual testing, unit testing
> 
> 
> File Attachments
> ----------------
> 
> Encapsulate field dialog
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/15/ea15c55b-cc4d-4dfa-ac34-8c568a93701d__snapshot3.png
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150721/ca7948a7/attachment-0001.html>