Review Request 124401: Don't add const and volatile modifiers to names of types

Milian Wolff mail at milianw.de
Tue Jul 21 14:25:23 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124401/#review82767
-----------------------------------------------------------

Ship it!



duchain/builder.cpp (line 123)
<https://git.reviewboard.kde.org/r/124401/#comment57071>

    the trim shouldn't be required anymore now, or?


- Milian Wolff


On July 21, 2015, 7:59 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124401/
> -----------------------------------------------------------
> 
> (Updated July 21, 2015, 7:59 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Otherwise we end up showing tooltips like: "const const auto".
> This happens because clang_getTypeSpelling prepends type modifiers for auto types.
> 
> 
> Diffs
> -----
> 
>   duchain/builder.cpp a04dd7a 
>   tests/files/types.cpp 193a148 
> 
> Diff: https://git.reviewboard.kde.org/r/124401/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150721/33aecf37/attachment.html>


More information about the KDevelop-devel mailing list