Review Request 124407: kdevplatform: Fix some foreach loop issues (krazy2)

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124407/#review82736
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On July 20, 2015, 8:40 p.m., Boris Egorov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124407/
> -----------------------------------------------------------
> 
> (Updated July 20, 2015, 8:40 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Fix krazy2 warnings about foreach usage. Mostly about const ref
> iterators usage; another issues (values for keys iteration) are not so
> easy to solve.
>     
> http://ebn.kde.org/krazy/reports/extragear/kdevelop/kdevplatform/index.html
> 
> 
> Diffs
> -----
> 
>   debugger/framestack/framestackwidget.cpp 8052ecf 
>   language/assistant/staticassistantsmanager.cpp 8c25c88 
>   language/backgroundparser/backgroundparser.cpp b109174 
>   language/backgroundparser/documentchangetracker.cpp b396750 
>   language/codecompletion/codecompletion.cpp 815dcd5 
>   language/codecompletion/codecompletionitem.cpp b581d76 
>   language/codegen/templatesmodel.cpp b0d24fe 
>   language/duchain/duchain.cpp fbee364 
>   language/duchain/duchainutils.cpp 8a26194 
>   language/highlighting/colorcache.cpp 53e4b73 
>   plugins/contextbrowser/browsemanager.cpp 67028b7 
>   plugins/contextbrowser/contextbrowser.cpp 8be67e9 
>   plugins/externalscript/externalscriptplugin.cpp 635cb3f 
>   plugins/grepview/grepdialog.cpp c2244c0 
>   plugins/grepview/grepfindthread.cpp 6cd456c 
>   plugins/grepview/tests/test_findreplace.cpp 4485de5 
>   plugins/projectmanagerview/vcsoverlayproxymodel.cpp a2ed4cf 
>   plugins/quickopen/projectfilequickopen.cpp b63b840 
>   plugins/quickopen/quickopenplugin.cpp 3561828 
>   plugins/testview/testview.cpp c9e1644 
>   project/projectutils.cpp 381cf7d 
>   shell/documentcontroller.cpp c2d0247 
>   shell/languagecontroller.cpp fb52deb 
>   shell/settings/sourceformattersettings.cpp 8f55474 
>   shell/tests/test_testcontroller.cpp b57afc1 
>   vcs/widgets/vcsdiffpatchsources.cpp d982fc9 
> 
> Diff: https://git.reviewboard.kde.org/r/124407/diff/
> 
> 
> Testing
> -------
> 
> Build and run tests (all passing).
> 
> 
> Thanks,
> 
> Boris Egorov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150720/8f6ee830/attachment.html>