Review Request 124369: Encapsulate field refactoring

[Maciej Poleski]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124369/
-----------------------------------------------------------

(Updated Lip 21, 2015, 12:37 rano)


Review request for KDevelop.


Changes
-------

Finished implementation (small improvements required)


Summary (updated)
-----------------

Encapsulate field refactoring


Repository: kdev-clang


Description (updated)
-------

Encapsulate field refactoring

- Displays dialog
- Transforms "use" site - replaces direct uses of encapsulated variable by calls to getter and setter method/function.
- Generates getter and setter implementation

Attached image presents GUI with its default content (prefilled by heuristics on DeclaratorDecl AST node).


Diffs (updated)
-----

  refactoring/CMakeLists.txt PRE-CREATION 
  refactoring/encapsulatefielddialog.h PRE-CREATION 
  refactoring/encapsulatefielddialog.cpp PRE-CREATION 
  refactoring/encapsulatefielddialog.ui PRE-CREATION 
  refactoring/encapsulatefieldrefactoring.h PRE-CREATION 
  refactoring/encapsulatefieldrefactoring.cpp PRE-CREATION 
  refactoring/encapsulatefieldrefactoring_changepack.h PRE-CREATION 
  refactoring/encapsulatefieldrefactoring_changepack.cpp PRE-CREATION 
  refactoring/redeclarationchain.cpp PRE-CREATION 
  refactoring/refactoringmanager.cpp PRE-CREATION 
  refactoring/tudecldispatcher.h PRE-CREATION 
  refactoring/tudecldispatcher.cpp PRE-CREATION 
  refactoring/utils.h PRE-CREATION 
  refactoring/utils.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124369/diff/


Testing (updated)
-------

Manual testing, tests are coming (tomorrow?)


File Attachments
----------------

Encapsulate field dialog
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/15/ea15c55b-cc4d-4dfa-ac34-8c568a93701d__snapshot3.png


Thanks,

Maciej Poleski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150720/de30b37a/attachment.html>