Review Request 124202: Adapt to new API in kdevplatform's IProjectBuilder::install(item, installPath)

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124202/
-----------------------------------------------------------

(Updated July 20, 2015, 1:34 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Changes
-------

Submitted with commit 0a031605490ddefba15df24195e676124b5b1a5e by Aleix Pol to branch master.


Repository: kdevelop


Description
-------

Implement the new API in kdevplatform.
- make: Use DESTDIR. https://www.gnu.org/prep/standards/html_node/DESTDIR.html
- ninja: Error out.
- custom make: create a DESTDIR environment variable and run install (I'm quite unsure of hte best approach TBH).

If anybody cares about kdev-qmake, it should pass INSTALL_ROOT instead of DESTDIR, but it works exactly the same way.


Diffs
-----

  projectbuilders/cmakebuilder/cmakebuilder.h 19a9c77 
  projectbuilders/cmakebuilder/cmakebuilder.cpp 949b344 
  projectbuilders/makebuilder/makebuilder.h 7c03d7f 
  projectbuilders/makebuilder/makebuilder.cpp fe85e2b 
  projectbuilders/ninjabuilder/kdevninjabuilderplugin.h 06b2154 
  projectbuilders/ninjabuilder/kdevninjabuilderplugin.cpp 4597447 
  projectmanagers/custom-buildsystem/custombuildjob.h 0e3516e 
  projectmanagers/custom-buildsystem/custombuildjob.cpp 487607e 
  projectmanagers/custom-buildsystem/custombuildsystemplugin.h 1771fbe 
  projectmanagers/custom-buildsystem/custombuildsystemplugin.cpp a850099 

Diff: https://git.reviewboard.kde.org/r/124202/diff/


Testing
-------


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150720/a2add277/attachment.html>