Review Request 124402: Extract TODO's for imports too

[Aleix Pol Gonzalez]

> On July 20, 2015, 11:03 a.m., Aleix Pol Gonzalez wrote:
> > duchain/todoextractor.cpp, line 170
> > <https://git.reviewboard.kde.org/r/124402/diff/1/?file=386306#file386306line170>
> >
> >     Again, auto-abuse, this isn't even shorter than:
> >     IndexedString path(QDir::cleanPath(ClangString(clang_getFileName
> >     (m_file)).toString()));
> 
> Milian Wolff wrote:
>     Aleix, you should get a copy of the latest Scott Meyers book and read that ;-) This is imo _not_ an abuse of auto - quite the contrary.
>     
>     @Sergey: leave it as is now, but feel free to use your initial version in the future again.

It's on my to-read list. OTOH, and without Scott's wisdom, I think we lose information by not being explicit. Note not even KDevelop can display what's the type of the symbol on hover, it's even harder as a human.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124402/#review82685
-----------------------------------------------------------


On July 20, 2015, 11:20 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124402/
> -----------------------------------------------------------
> 
> (Updated July 20, 2015, 11:20 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> To tokenize an included file we need a location containing the whole file, for that we pass max uint value to the clang_getLocation. Clang can correctly handle that case.
> 
> 
> Diffs
> -----
> 
>   duchain/parsesession.cpp c573691 
>   duchain/todoextractor.h 806a264 
>   duchain/todoextractor.cpp e7d9b20 
>   tests/test_problems.h cc0ec8c 
>   tests/test_problems.cpp b039bcf 
> 
> Diff: https://git.reviewboard.kde.org/r/124402/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150720/b1cac045/attachment.html>