Review Request 124402: Extract TODO's for imports too
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Jul 20 09:03:21 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124402/#review82685
-----------------------------------------------------------
duchain/todoextractor.cpp (line 170)
<https://git.reviewboard.kde.org/r/124402/#comment57028>
Again, auto-abuse, this isn't even shorter than:
IndexedString path(QDir::cleanPath(ClangString(clang_getFileName
(m_file)).toString()));
- Aleix Pol Gonzalez
On July 20, 2015, 10:56 a.m., Sergey Kalinichev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124402/
> -----------------------------------------------------------
>
> (Updated July 20, 2015, 10:56 a.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdev-clang
>
>
> Description
> -------
>
> To tokenize an included file we need a location containing the whole file, for that we pass max uint value to the clang_getLocation. Clang can correctly handle that case.
>
>
> Diffs
> -----
>
> duchain/parsesession.cpp c573691
> duchain/todoextractor.h 806a264
> duchain/todoextractor.cpp e7d9b20
> tests/test_problems.h cc0ec8c
> tests/test_problems.cpp b039bcf
>
> Diff: https://git.reviewboard.kde.org/r/124402/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Kalinichev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150720/31326ee4/attachment.html>
More information about the KDevelop-devel
mailing list