Review Request 124401: Don't add const and volatile modifiers to names of types

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124401/#review82684
-----------------------------------------------------------



duchain/builder.cpp (line 118)
<https://git.reviewboard.kde.org/r/124401/#comment57027>

    This looks like an abuse of auto, I would just use it only when the type it's going to get is somewhere else in the line already. (e.g. auto v = new vector;)
    
    Also are these all of the keywords we're all ever going to need? It would be cool to add a comment pointing out how to know how to fix in the future.


- Aleix Pol Gonzalez


On July 20, 2015, 10:51 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124401/
> -----------------------------------------------------------
> 
> (Updated July 20, 2015, 10:51 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Otherwise we end up showing tooltips like: "const const auto".
> This happens because clang_getTypeSpelling prepends type modifiers for auto types.
> 
> 
> Diffs
> -----
> 
>   duchain/builder.cpp a04dd7a 
>   tests/files/types.cpp 193a148 
> 
> Diff: https://git.reviewboard.kde.org/r/124401/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150720/c91df7f5/attachment.html>