Review Request 124256: Introduce rename field refactoring

Milian Wolff mail at milianw.de
Wed Jul 15 22:29:37 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124256/#review82556
-----------------------------------------------------------

Ship it!



refactoring/renamefielddeclturefactoring.cpp (line 77)
<https://git.reviewboard.kde.org/r/124256/#comment56943>

    one level less indentation, and one member/base class per line, braces on their own lines


- Milian Wolff


On July 10, 2015, 6:12 p.m., Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124256/
> -----------------------------------------------------------
> 
> (Updated July 10, 2015, 6:12 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Renaming of fields with external linkage.
> 
> Renaming of fields from classes in anonymous namespaces is also done
> 
> 
> Diffs
> -----
> 
>   refactoring/CMakeLists.txt PRE-CREATION 
>   refactoring/refactoringmanager.cpp PRE-CREATION 
>   refactoring/renamefielddeclrefactoring.h PRE-CREATION 
>   refactoring/renamefielddeclrefactoring.cpp PRE-CREATION 
>   refactoring/renamefielddeclturefactoring.h PRE-CREATION 
>   refactoring/renamefielddeclturefactoring.cpp PRE-CREATION 
>   refactoring/renamevardeclrefactoring.h PRE-CREATION 
>   refactoring/renamevardeclrefactoring.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124256/diff/
> 
> 
> Testing
> -------
> 
> Manual testing
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150715/31df38db/attachment.html>


More information about the KDevelop-devel mailing list